#4749 migrate darkserver from puppet to ansible
Closed: Fixed None Opened 8 years ago by kevin.

Take the puppet/modules/darkserver module and manifests/nodes/darkserver01.phx2.fedoraproject.org and migrate them over to ansible.

Should mostly be a ansible/roles/darkserver/ role, but we also need a playbooks/groups/darkserver.yml playbook that does all the normal stuff we do on servers (look in that dir for examples).


I'm working on this, just did all the templates from .erb into j2, but still need more time to finish the translation of the task from init.pp into main.yml

alvesadrian, are you still working on this?

I could help out with this but not sure if previous commenters are working on this. Could someone confirm?

@cortopy, i was going to pick up working on this one. Was just giving alvesadrian time to respond. Although, if you want to tag-team it i'd wouldn't mind the help.

@pcreech17, are you working on that issue?

@pklos, unfortunately I am not.

Shortly after I took ownership, i have become unable to devote the time to this issue. It is up for grabs.

No problem. I'll take it.

I have attached my proposal version of darkserver migration from puppet to ansible.

Review please :)

List of variables to be set in private repo v0.1
darkserver_priv_vars.list

Sorry for the delay here. ;)

Some review comments:

  • No need to set selinux enforcing (thats the default).

  • Don't use lineinfile for iptables. We have a template setup for that. Look at other hosts. :) We just need a host_vars/darkserver* host variable to allow port 80/443.

  • We shouldn't need clamav here...

  • We will be using rhel6 here for now, so don't use dnf, use yum.

  • No need to check for darkserver being installed to install config files, if it's not the play that installs it would fail.

Can you create a v2 patch with the above addressed?

Thanks for working on this!

Did a few changes, but overall looks good. ;)

Thanks.

Login to comment on this ticket.

Metadata