#4680 genacls job trying to create existing branches
Closed: Fixed None Opened 6 years ago by kevin.

From cron (but I imagine the fedmsg triggered ones are doing this too):

Subject: Cron root@pkgs02 /usr/local/bin/genacls.sh
Date: Fri, 6 Mar 2015 10:02:18 +0000 (UTC)

IGNORING: Package module libguestfs already has a branch f21

Creating new module branch 'f21' for 'libguestfs'...
fatal: A branch named 'f21' already exists.
ERROR: Branch libguestfs f21 could not be created
/usr/local/bin/mkbranch: line 153: popd: directory stack empty
libguestfs missing: el5,f20,f21
Traceback (most recent call last):
File "/usr/local/bin/pkgdb_sync_git_branches.py", line 246, in <module>
File "/usr/local/bin/pkgdb_sync_git_branches.py", line 237, in main
branch_package(pkg, diff)
File "/usr/local/bin/pkgdb_sync_git_branches.py", line 203, in branch_package
_create_branch(pkgname, branch)
File "/usr/local/bin/pkgdb_sync_git_branches.py", line 116, in _create_branch
_invoke(MKBRANCH, [branch, pkgname])
File "/usr/local/bin/pkgdb_sync_git_branches.py", line 97, in _invoke
raise e

Looks like it started:

Mar 05 12:55:46 <fedmsg-bot> git.branch -- pkgdb created branch 'master' for the 'libguestfs' package http://pkgs.fedoraproject.org/cgit/libguestfs.git/log/?h=master
Mar 05 12:55:47 <fedmsg-bot> git.branch -- pkgdb created branch 'f22' for the 'libguestfs' package http://pkgs.fedoraproject.org/cgit/libguestfs.git/log/?h=f22

Possibly some commit is confusing it?

ok, so the problem here is that our script isn't as smart as git. ;)

git helpfull packs refs if it decides it would save time/downloads/whatever.

This is what happened to the libguestfs repo. It packed all the refs older than f22. Our script just looks in the refs/heads/ dir for heads, but that doesn't find them in the packed refs.

So, likely we need to look at switching it to call something like 'git show-ref --heads refs/heads/$branchname' to tell if there's a branch/heads.

ok, sorry this took so long, but we have pushed a fix out for this.

It should no longer be saying it made a libguestfs branch that didn't need creation.

It should now process all the way through and add all the right acls and package branches.

Please let us know if you see any issues or errors.

Login to comment on this ticket.