#4075 Package Review tracker
Closed: Fixed 7 years ago Opened 10 years ago by paragn.

I confused when my eyes failed to understand whats written exactly on http://fedoraproject.org/PackageReviewStatus/NEEDSPONSOR.html as "This page lists all new NEEDSPONSOR tickets (those without the fedora-revlew flag set)."

The reason maybe the word "review" is written actually as "revlew". Please fix this.

Also, Can we have one more tracker that shows Need Sponsor tickets which are already under review? Maybe its helpful for people who want to see if any tickets are stalled for NeedSponsor which are under review.


Fixed in puppet by commit 6d87afa.
But I (probabaly) do not have rights to apply it on targeted machine. Somebody please finish it.

added link to all BZs blocking FE-NEEDSPONSOR in commit f6a683d

Replying to [comment:1 msuchy]:

Fixed in puppet by commit 6d87afa.
But I (probabaly) do not have rights to apply it on targeted machine. Somebody please finish it.

Puppet will take care or deploying it, so all we need to do is wait that it runs

Not sure where that commit was done, but if it wasn't done in the upstream source tree it will just be overwritten. And if it was done in the upstream source tree, that needs to get copied into puppet, but of course infrastructure is frozen in any case so no changes can be made currently.

Yeah, should have noted we are in freeze and shouldn't have pushed this. ;(

Tibbs: can you fold these changes into the upstream repo?

I haven't seen the changes; I'm not even sure where they are. But if someone wants to attach a patch I'll be happy to try and get it upstream.

Unfortunately I think there are a couple of other changes made upstream which might now conflict, so I'll have to sort that out.

The changes are in puppet itself, do you have access to it? Otherwise I can find back the emails containing the diff(s).

Actually the "fix" doesn't actually work; I'm just getting tracebacks mailed to me at each run, and the pages aren't updating.

Traceback (most recent call last):
File "/usr/local/bin/review-stats.py", line 640, in <module>
subs['needsponsor'] = report_needsponsor(usermap=usermap, **args)
File "/usr/local/bin/review-stats.py", line 543, in report_needsponsor
write_html(loader, 'needsponsor.html', data, tmpdir, 'NEEDSPONSOR.html')
File "/usr/local/bin/review-stats.py", line 313, in write_html
tmpl = loader.load(template)
File "/usr/lib/python2.6/site-packages/genshi/template/loader.py", line 227, in load
filename, encoding=encoding)
File "/usr/lib/python2.6/site-packages/genshi/template/loader.py", line 265, in _instantiate
allow_exec=self.allow_exec)
File "/usr/lib/python2.6/site-packages/genshi/template/base.py", line 379, in init
raise TemplateSyntaxError(e.msg, self.filepath, e.lineno, e.offset)
genshi.template.base.TemplateSyntaxError: not well-formed (invalid token): line 43, column 74 (/usr/local/share/review-stats/templates/needsponsor.html, line 43)

So, uh, I'll dig the patch out and try to fix it, when I have some time. But could someone revert this for me, so we at least have working pages?

commits:

{{{
commit f6a683dd474f3140e88a48f451f759e50fba5d62
Author: Miroslav Suchý msuchy@redhat.com
Date: Tue Oct 22 07:18:41 2013 +0000

add link to all BZs blocking FE-NEEDSPONSOR

diff --git a/modules/review-stats/files/templates/needsponsor.html b/modules/review-stats/files/templates/needsponsor.html
index 25a5e2a..073650c 100644
--- a/modules/review-stats/files/templates/needsponsor.html
+++ b/modules/review-stats/files/templates/needsponsor.html
@@ -40,6 +40,7 @@ PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"

$description


Click the name to find all comments made in any review tickets.

In parentheses is the date their oldest submission was made.

+https://bugzilla.redhat.com/buglist.cgi?bug_status=NEW&bug_status=ASSIGNED&classification=Fedora&component=Package%20Review&f0=OP&f1=OP&f2=blocked&f3=CP&f4=OP&f5=flagtypes.name&f6=CP&f7=CP&j1=OR&j4=OR&known_name=reviewes%20need%20sponsor&list_id=1828876&o2=substring&o5=notequals&product=Fedora&query_based_on=reviewes%20need%20sponsor&query_format=advanced&v2=177841&v5=fedora%E2%80%91review%3F">List of all NEEDSPONSOR reviews (including already taken reviews).

Last Update: $update (v$version)

There are $count tickets in this category

commit 6d87afa92939ae7173104498939296ffb7da81d4
Author: Miroslav Suchý msuchy@redhat.com
Date: Tue Oct 22 07:04:51 2013 +0000

fix typo s/revlew/review/

diff --git a/modules/review-stats/files/review-stats.py b/modules/review-stats/files/review-stats.py
index 1e60d27..93887f8 100755
--- a/modules/review-stats/files/review-stats.py
+++ b/modules/review-stats/files/review-stats.py
@@ -502,7 +502,7 @@ def report_merge(bugs, bugdata, loader, tmpdir, subs):

def report_needsponsor(bugs, bugdata, loader, usermap, tmpdir, subs):
data = deepcopy(subs)
- data['description'] = 'This page lists all new NEEDSPONSOR tickets (those without the fedora-revlew flag set).'
+ data['description'] = 'This page lists all new NEEDSPONSOR tickets (those without the fedora-review flag set).'
data['title'] = 'NEEDSPONSOR tickets'
curreporter = ''
curcount = 0
}}}

reverted the first one for now until we can sort it out. ;)

This turn into a mess. The typo fix has been in there for ages and I merged all of the changes that should have been made upstream into ansible. Also added a loud warning about not making changes directly in ansible.

Will see about the additional report which was requested.

@tibbs Should this be closed now, or was there something outstanding?

:hourglass_flowing_sand:

The actual reported bugs were fixed, yes. The separate feature request really should have been a separate feature request.

I keep hoping that this code can just go away, but nothing appears to be happening with Fresque.

This code now being in pagure means that someone could at least send a PR if they want to see changes in the script.

ok. I will close this and @paragn can file the feature request if thats still desired. Thanks.

:airplane:

@kevin changed the status to Closed

7 years ago

Login to comment on this ticket.

Metadata