#4011 Convert the fedmsg task to a role in ansible
Closed: Fixed None Opened 6 years ago by pingou.

At the moment the fedmsg_base is a task which means it's run after the roles in a playbook. This is annoying when another role depends on fedmsg being configured.

Converting fedmsg_base from a task to a role would solved this problem.


Let me have a look at this one. Hopefully I can solve the problem.

Here is what I've managed to do. Hopefully this is in the right direction and leading towards solution. I hope somebody will have a look at this and give me some feedback.

Changing fedmsg_task to a role in ansible.
fedmsg_base.patch

This looks good at first glance. I want to give it a closer look just to be sure, though. Nice work!

Also, I want to note that if the Beta freeze starts on Tuesday and if we don't get this merged into our ansible tree by then, we'll have to wait until the freeze lifts.

See: http://infrastructure.fedoraproject.org/infra/docs/fedora-releases.txt

janeznemanic, I applied this tonight here: http://infrastructure.fedoraproject.org/cgit/ansible.git/commit/

It was solid! Thanks!

Login to comment on this ticket.

Metadata