#3999 port ./modules/puppet/files/check_puppet_run.py to ansible
Closed: Fixed None Opened 10 years ago by kevin.

./modules/puppet/files/check_puppet_run.py in puppet is a func script that looks up puppet yaml files and sends reports when things change or error. We need to change this to use ansible instead of func.


Could I take a look at this?

@sheap sure go ahead. I am working on 4000 and waiting for a review. That could be a helper point. Or you can work it in your own way.

@sheap Is it okey with you if I have a look at this one too. It seems very interesting. What about if we work together?

hi guys, any update on this?

Hi, I'm actively working on this. Think I've managed to port most of the script. Just need to change the final part of the script. Then I will publish my solution.

You can find my solution in attachments. Have a look at it, correct it, improve it. Or just report what is not ok.

This looks pretty good from a quick glance. ;)

We need to wait for freeze to be over (on wed) and then we can land it.

Please do ping me after freeze and we can get it deployed.

Thanks a bunch for working on it.

ok. Looking more at this we are going to have to be a bit more clever.

The problem is that we can't use all hosts in the ansible inventory, because many of them don't use puppet at all. We only want this to act on the ones that do use puppet.

Can you look at ticket #4000 and see if the puppet ca list used in that script will work here? That should give a list of all the hosts signed in puppet.

I'll have a look tomorrow. I think it should be possible to apply solution from ticket #4000.

Hopefully the solution from ticket #4000 will work. Let's try with this.

One more thing. If there is something wrong with the script, could you provide a sample output from command: puppet cert list -all.

ok. I moved this into production. ;) There was a typo (missing ',' on one line), but otherwise it worked great.

Additionally, the old func one seems to have been broken, so it showed a number of hosts that needed new puppet certs to start working again. ;)

Thanks a bunch for working on this!

Login to comment on this ticket.

Metadata