#3721 Broken gravatars: E-mail is not set in preferences, when logged in using FAS
Closed: Fixed None Opened 11 years ago by churchyard.

= bug description =
When an user logs in to any fedorahosted.org trac, his e-mail address is not imported to Preferences and that means his gravatar is not shown.

When an user wants his gravatar to be shown, he must go to preferences and fill in his e-mail address -> on each fedorahosted.org trac.

= bug analysis =
Currently only the FAS username is passed to the gravatar service, so no proper gravatar is shown, as the service is e-mail address focused/based.

But fedorahosted.org knows my e-mail address, as it sends me e-mails properly.

= fix recommendation =
Either:

1) send to the gravatar API the same e-mail address you send e-mails to

2) append @fedoraproject.org to the FAS username, that is sent to gravatar API

(Both solutions might end up the very same way, if you send e-mails to @fedoraproject.org addresses)


There should not be any need for users to edit their email address, and it should be checking for the users fedoraproject.org address.

Can you give me an example where you see this? We will try and track it down...

My gravatar here is https://gravatar.com/avatar/ca04d46242ed51a577279c02fe65394b?size=40

Hash ca04d46242ed51a577279c02fe65394b represents churchyard

$ echo -n churchyard | md5sum

ca04d46242ed51a577279c02fe65394b -

churchyard@fedoraproject.org is represented by other hash and has this URL:

https://gravatar.com/avatar/38af6b35773d327390777d1849ffdf7d

You can see my pretty face there

I could have sworn this worked by default, but it doesn't seem to be anymore.

Will investigate more... thanks for the report.

So, I dug into this... it seems our current auth setup isn't setting email address properly, so you have to enter it into prefs in order for things to come out right.

We are very soon switching to openid, which will do things correctly. ;)

Unfortunately, anyone who has logged in with the old auth method will have a local account already and the openid login will just log you into that one (without the email set in prefs unless you do so).

So, unfortunately, there's no good answer for existing accounts other than 'please set your email in prefs'.

Moving forward new accounts/users should be fixed soon.

Sorry we don't have a complete fix, but at least it should be better for new accounts very soon.

Replying to [comment:5 kevin]:

Unfortunately, anyone who has logged in with the old auth method will have a local account already and the openid login will just log you into that one (without the email set in prefs unless you do so).

So, unfortunately, there's no good answer for existing accounts other than 'please set your email in prefs'.

Is this each trac specific, or I'll have to set the e-mail address in each trac I log in, for ever and ever?

Thanks.

Is is per trac specific.

You will need to set email on any trac you logged into so far.

After we roll openid out to all the instances, you will not need to set email on any that you login to for the first time after that.

Really the only way we could fix this is to edit all trac instances db's and set everyone's emails (which is very invasive and would require us to litterally touch every single user on every single trac) or remove all users which would cause them to be recreated by openid plugin (but would also cause them to forget all their other perfs like language and other things). Neither of these are a good option IMHO, so I think we just ask folks to set emails for now and know that it will be better after openid.

OK, works for me, thank you.

Login to comment on this ticket.

Metadata