#343 livecd git commit mails originate from the wrong email address
Closed: Fixed None Opened 16 years ago by markmc.

If I push commits to git/hosted/livecd, the commit emails seem to originate from markmc@hosted1.fedoraproject.org instead of markmc@redhat.com or markmc@fedoraproject.org, causing them to bounce

e.g.

From: Mark McLoughlin markmc@hosted1.fedoraproject.org
To: fedora-livecd-list@redhat.com
Date: Mon, 14 Jan 2008 01:16:32 -0700
Subject: imgcreate/creator.py
imgcreate/creator.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit f1603e813cbf448088b174474d0ec7cb86d93e28
Author: Mark McLoughlin markmc@redhat.com
Date: Mon Jan 14 08:16:26 2008 +0000


Aha, I was wondering why I wasn't seeing this myself for a moment. Try running:

{{{
git config --global user.name "Mark McLoughlin"
git config --global user.email "markmc@fedoraproject.org"
}}}

on the computer that you're committing from. I think this ends up forming the From header on the commit emails - let me know if it works.

I haven't tried this because I have both $GIT_AUTHOR_EMAIL and $GIT_COMMITTER_EMAIL set, which should have the same effect. e.g. the last commit I made have the correct address in both the author and committer fields set:

http://git.fedoraproject.org/git/?p=livecd;a=commit;h=5c61597aa68e489abd0abf4c9ab67e7768df76a6

Also, since I don't see the emails being sent out, I can't really experiment.

Interestingly, the last commit mail that made it to the list is:

http://www.redhat.com/archives/fedora-livecd-list/2007-December/msg00021.html

which corresponds to:

http://git.fedoraproject.org/git/?p=livecd;a=commit;h=40ca06a845e8c81d3d29ee30f85a5a7f2d3c7af9

Note - the commit mail originates from svahl@fedoraproject.org rather than the committer email address, fedora@deadbabylon.de

So, it seems to me there are two things going on here:

  • commit mails used to originate from committer@fedoraproject.org, but now originate
    from committer@hosted1.fedoraproject.org

  • it'd be better if commit mails originated from the committer email address, rather
    than any other address, but this is less of an issue

I've added a regular expression "^.@hosted.fedoraproject.org" in "accept_these_nonmembers" for fedora-livecd-list

Sorry for the wait, but this should finally be fixed now (commit mail should always be from user@fedoraproject.org, which forwards to the committer's actual email address).

Login to comment on this ticket.

Metadata