#3302 trac-code-comments plugin
Closed: Fixed None Opened 11 years ago by codeblock.

So one thing I think would be cool to offer on Fedora Hosted is a way to comment on commits (or lines of code changed in a commit), much like Github offers.

I did some looking around and came across https://github.com/Automattic/trac-code-comments-plugin which does exactly that. You can see the readme file there for screenshots.

It claims to need Python 2.4+ and Trac 0.12+, both of which we have, and it uses Trac wiki markup for parsing comments. It's licensed under GPLv2+.

I'd be willing to package it up, but wanted to ask for thoughts before I do so, so I don't waste time if everyone hates it. :)

To me, it seems like a neat idea, and something I would use on the 'fedorahosted' project trac.

Thoughts?


Sure, looks interesting. If you want to package it, I'd be happy to review/co-maintain.

I do maintain several trac plugins, let me know if you need any help in packaging it. A few examples are available at http://averi.fedorapeople.org/RPMs.

Alright, cool. I will probably package this up this weekend or early next week.

Kevin - Do you know where this stands right now: http://fedoraproject.org/wiki/JavaScript_libraries_packaging_guideline_draft

The comments plugin does bundle some JS libraries in it, but I am not sure if that draft ever became more than a draft, so I'm not sure if this matters.

Notably, it bundles:

  • Backbone
  • json2
  • jquery.ba-throttle-debounce
  • underscore

as seen here: https://github.com/Automattic/trac-code-comments-plugin/tree/master/code_comments/htdocs

Pending this, I almost have something ready for review.

Thats all still a draft, and for now, I think bundling js is allowed.

I've added this to hosted.

Currently it's not enabled by default. I have enabled it in the fedora-infrastructure instance however.

Login to comment on this ticket.

Metadata