#20 Makefile.common wrecks mockbuild for epel
Closed: Fixed None Opened 16 years ago by static.

The current Makefile.common in CVS is incorrectly configured for "make mockbuild" in EPEL. Starting on line 44 it tries to figure out which mock.cfg file to use to set up the mock environment.

First it checks for epel and correctly chooses the right .cfg file.
Immediately after that, however, it does a blunt check for version 4 (then 5 and 6) and then chooses the appropriate FC mock.cfg file, overwriting any previous .cfg selection. The end result is when running a "make mockbuild" for epel4 or epel5, mock tried to use a .cfg file for fc4 or fc5, respectively.

To solve this, the section of DISTVAL, [456] checks needs to be wrapped in a check for fedora first. See attached patch for details.


Login to comment on this ticket.

Metadata