The web interface doesn't expose this, but perhaps its:

https://pagure.io/fedora-infra/ansible/blob/main/f/roles/mailman/files/mailman-template-list-member-generic-footer.txt

I'm not sure why '___________" was used instead of '-- '

@tmz made that commit, perhaps there was a reason?

It was added as an edited version of the default template, which uses underscores.

[backlog refinement]
The template will need to be changed for the mailing list. We just need to find some spare cycles.

@pspacek @kevin @tmz
Diff review before I submit a Merge Request:

diff --git a/roles/mailman/files/mailman-template-list-member-generic-footer.txt b/roles/mailman/files/mailman-template-list-member-generic-footer.txt
index 162ab92f50..524c5695bd 100644
--- a/roles/mailman/files/mailman-template-list-member-generic-footer.txt
+++ b/roles/mailman/files/mailman-template-list-member-generic-footer.txt
@@ -1,4 +1,4 @@
-_______________________________________________
+-----------------------------------------------
 $display_name mailing list -- $listname
 To unsubscribe send an email to ${short_listname}-leave@${domain}
 Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/

Essentially, this is the right idea. But the change requested is to use the literal string "--" which is the traditional signature separator for email. (That's "dash dash space" in case the pagure formatting doesn't insert it exactly as written -- as the preview indicates it will not.)

I imagine that when it's changed it will break someone else's expectations and/or tools (https://xkcd.com/1172/). It may perhaps be less noticeable to not replace the existing underscores but simply add the -- line just before it in the template. But that may be overkill.

Ideally this sort of change would be made (or at least proposed) in upstream mailman too, but that's just my opinion.

@tmz Something more along this ?

diff --git a/roles/mailman/files/mailman-template-list-member-generic-footer.txt b/roles/mailman/files/mailman-template-list-member-generic-footer.txt
index 162ab92f50..21aaf93995 100644
--- a/roles/mailman/files/mailman-template-list-member-generic-footer.txt
+++ b/roles/mailman/files/mailman-template-list-member-generic-footer.txt
@@ -1,3 +1,4 @@
+--
 _______________________________________________
 $display_name mailing list -- $listname
 To unsubscribe send an email to ${short_listname}-leave@${domain}

Pretty close. There should be a trailing space after the -- and no quotes. (Though perhaps you have a space and pagure's markdown library has eaten it?)

In the preview, it seems to keep it. With luck this will come through as I've typed it:

diff --git a/roles/mailman/files/mailman-template-list-member-generic-footer.txt b/roles/mailman/files/mailman-template-list-member-generic-footer.txt
index 162ab92f50..1f49eb74ac 100644
--- a/roles/mailman/files/mailman-template-list-member-generic-footer.txt
+++ b/roles/mailman/files/mailman-template-list-member-generic-footer.txt
@@ -1,3 +1,4 @@
+-- 
 _______________________________________________
 $display_name mailing list -- $listname
 To unsubscribe send an email to ${short_listname}-leave@${domain}

This is done. I was thinking we would just do it for that list, but looks like it was applied globally... which is fine with me, will see if anyone complains. ;)

Thanks for the PR @aheath1992

I see it on the users list and while the commit in ansible has the trailing space, it is not included in the messages I've seen. I suspect that will make it less useful as no sane mail client should treat ^--$ as a signature separator.

I don't know if that didn't apply the whitespace to mailman or if something in mailman is eating the trailing space.

FTR mailman itself is certainly not easting the trailing space, there is bunch of lists using that delimiter, e.g. https://lists.ripe.net/mailman/listinfo/dns-wg

That looks like mailman2, so it could still be something in the old mailman3 which Fedora is running. Ideally it isn't, of course. :)

The space is there in the template file for mailman3 as well... so it must somehow be dropping it when it reads it?

It's a bug.

It was fixed more than 2 years ago in mailman 3.3.5, in upstream 73f52cb80 (Don't remove trailing spaces from header/footer templates., 2021-08-04).

It should be easy to apply the fix while we wait on a mailman3 update for the Fedora lists.

Ha. Figures. Well, we are finally getting close to moving to a current/reasonable deployment.

I guess we should just close this for now, and it will be fixed when we move to the new one.