See e.g. https://apps.fedoraproject.org/datagrepper/id?id=2021-46698f05-9b08-4b0f-ba6c-7efe7091cd47&is_raw=true&size=extra-large
Right now, these messages pass on the entire json sent by the webhook. I think we should not include the actual message bodies, because this could among other things mean spam goes into the message bus, and, ugh. If a responder needs to get the "cooked" message body, they can use the API, and if there's a case where we need the raw one, we can set up specific webhooks.
So, please remove msg.webhook_body.raw and msg.webhook_body.cooked before putting onto the bus.
msg.webhook_body.raw
msg.webhook_body.cooked
Ideally soon, as we are sending these messages onto the bus now.
Metadata Update from @zlopez: - Issue assigned to ryanlerch - Issue tagged with: dev, low-trouble, medium-gain
Done:
https://apps.fedoraproject.org/datagrepper/id?id=2021-8ab5ca8d-1cbd-4686-8b0d-69dd80b4d685&is_raw=true&size=extra-large
So, it only removes / filters "cooked" and "raw" from the posts items, e.g.:
msg.webhook_body.post.raw
and
msg.webhook_body.post.cooked
which i think is the only place it appears -- hard to tell cos these messages from discourse arent really documented anywhere.
@mattdm, just keep an eye on the webhooks consoles in the discouse instances to see if there are any errors after this change.
cheers, ryanlerch
Metadata Update from @ryanlerch: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.