Currently fas2 is still running in read-only mode. We should drop it entirely now.
Before we can do that we need to identify anything that breaks when it goes away.
Currently:
sigul bridge breaks because it tries to look up the 'signers' group and confirm a signing request is from someone in that group. We need to port this check to fasjson.
badges breaks because ? but it does.
Any other things?
We can't do this now since we are in final freeze, but we can work on it now and retire it after final freeze is over.
Metadata Update from @kevin: - Issue priority set to: Waiting on Assignee (was: Needs Review) - Issue tagged with: medium-gain, medium-trouble, ops, unfreeze
For sigul: Patrick and I talked and we decided it was ok to just disable that check on the bridge. Should just be a config change.
For badges, I am not sure...
does zodbot get its info from fas2 still? that'll break if it does...
The sponsor information is also only in FAS2 right now, because it was forgotten in the FAS2->Noggin migration: https://github.com/fedora-infra/noggin/issues/626
It does not. It gets info from fasjson/new account system now.
I don't think thats a blocker for retiring fas2. It's unfortunate, but if we wait for that we will be waiting a long time I fear.
@nirik just fyi I have a PR on sigul that makes the port to fasjson. It's been a good while since I looked at it but it's here if it's of any use to you: https://pagure.io/sigul/pull-request/3# might be an alternative to not performing the check.
Ah ha. Yeah, that could be good... need to get that merged and a new release out and deployed, but something we should do anyhow most likely. :)
IIRC, the only spot in badges that uses FAS is this:
https://github.com/fedora-infra/fedbadges/blob/develop/fedbadges/utils.py#L111
and pretty sure it is only used when awarding a badge -- to check if the user exists before awarding it.
I hotpatched a fix for this on badges stage (and forgot i did it) -- anyhoo
opened the following ticket to track getting the fix into fedbadges (badges-backend01) on prod:
https://pagure.io/fedora-infrastructure/issue/10270
Badges now uses fasjson, so just sigul remaining i suppose.
Yep. All we need is to hotfix the bridge or get a new sigul release and then I think we can take it down.
https://pagure.io/sigul/pull-request/9
@puiterwijk any chance you could do a new release? failing that, @ryanlerch can you do a patched rpm in our epel8-infra tag?
ok, I talked with Patrick about this a while back and we decided it was ok to just disable that check.
So, I am doing that now.
On poking at logs and looking around... notifs-backend01 is using it. ;(
So, thats another reason to do something with notifs, it's blocking this.
We are still blocked by notifs-backend. Hopefully we can get the python3/fasjson version rolled out soon tho to unblock it.
Metadata Update from @kevin: - Issue tagged with: blocked
We unblocked notifs and badges (converting them to use fasjson)
I have scaled fas2 down to 0.
I've removed it from ansible repo.
Thanks for everyones hard work on this!
Metadata Update from @kevin: - Issue close_status updated to: Fixed with Explanation - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.