#68 Drop the user_notifications configuration key
Merged 3 years ago by pingou. Opened 3 years ago by pingou.

@@ -25,7 +25,6 @@ 

              "server": "https://pdc.fedoraproject.org/rest_api/v1",

          },

          # distgit_bugzilla_sync config values

-         "user_notifications": False,

          "ignorable_accounts": [],

          "fasjson": False,

          "default_qa_contact": "nurgle@fedoraproject.org",
@@ -510,7 +509,6 @@ 

          """Assert that `xmlrpc.client.ProtocolError` is reported correctly."""

          # Adjust config

          config["temp_folder"] = tmpdir

-         config["user_notifications"] = True

          # Mock toml load

          email_overrides = Mock()

          mock_toml.return_value = email_overrides
@@ -624,7 +622,6 @@ 

          """Assert that `xmlrpc.client.Error` is reported correctly."""

          # Adjust config

          config["temp_folder"] = tmpdir

-         config["user_notifications"] = True

          # Mock toml load

          email_overrides = Mock()

          mock_toml.return_value = email_overrides
@@ -1270,7 +1267,6 @@ 

          """Assert that user_cache is used if exists."""

          # Adjust config

          config["temp_folder"] = tmpdir

-         config["user_notifications"] = True

  

          # Prepare user cache

          data = {

That key was present only in the tests and not used anywhere else
in the code.
The toddler distgit-bugzilla-sync does not warn any user that their
account are incorrectly set-up. This is achived by the toddler:
packager-without-bugzilla which runs daily.

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

Build succeeded.

  • tox : SUCCESS in 6m 19s

Thanks for the review :)

Pull-Request has been merged by pingou

3 years ago
Metadata