#65 Do not update the initialqacontact un-necessarily
Merged 3 years ago by pingou. Opened 3 years ago by pingou.

@@ -427,10 +427,13 @@ 

      if description and component["description"] != description:

          data["description"] = description

  

-     if qa_contact and component["initialqacontact"].lower() != qa_contact.lower():

+     if qa_contact and (

+         component["initialqacontact"] is None

+         or component["initialqacontact"].lower() != qa_contact.lower()

+     ):

          data["initialqacontact"] = qa_contact

      # Be explicit about removing the qacontact from Fedora components

-     elif qa_contact is None:

+     elif qa_contact is None and component["initialqacontact"] is not None:

          data["initialqacontact"] = ""

  

      if len(component["initialcclist"]) != len(cc_list):

Basically without this we kept on updating the initialqacontact
field even when it had already been reset.

While at it fix the comparison between the current and the old
and new value for the initialqacontact field.

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

rebased onto eaaacaf

3 years ago

Makes sense. Shippit!

Build succeeded.

  • tox : SUCCESS in 6m 59s

Pull-Request has been merged by pingou

3 years ago