PR#380: Always respect the value of initial_commit when creating new repo - fedora-infra/toddlers - Pagure.io

fedora-infra / toddlers

#380 Always respect the value of initial_commit when creating new repo

Closed 3 months ago by zlopez. Opened 3 months ago by zlopez.

fedora-infra/ zlopez/toddlers production into main

Always respect the value of initial_commit when creating new repo

Karolina Surma • 3 months ago

1f038cf

tests/plugins/test_scm_request_processor.py

file modified

+3 -1

		`@@ -715,7 +715,9 @@`
		`) as mock_create_new_repo:`
		`self.toddler.process_comment(issue)`

		`- mock_create_new_repo.assert_called_with(issue, {"action": "new_repo"})`
		`+ mock_create_new_repo.assert_called_with(`
		`+ issue, {"action": "new_repo"}, initial_commit=True`
		`+ )`

		`def test_process_comment_valid_command_wrong_action(self):`
		`"""`

toddlers/plugins/scm_request_processor.py

file modified

+5 -1

		`@@ -256,7 +256,11 @@`
		`)`
		issue_body_json = json.loads(issue["content"].strip("`").strip("\n"))
		`if issue_body_json.get("action") == "new_repo":`
		`- self._create_new_repo(issue, issue_body_json)`
		`+ self._create_new_repo(`
		`+ issue,`
		`+ issue_body_json,`
		`+ initial_commit=issue_body_json.get("initial_commit", True),`
		`+ )`
		`else:`
		`self.pagure_io.add_comment_to_issue(`
		`issue["id"],`

zlopez commented 3 months ago

The creation of new repo behaves differently if triggered by the 'retry'
and 'valid' commands. This commit unifies the behavior.

Metadata

Assignee

None

Tags

No Tags

Changes Summary 2

file changed

tests/plugins/test_scm_request_processor.py

file changed

toddlers/plugins/scm_request_processor.py

Powered by Pagure 5.14.1

Documentation • File an Issue • About • SSH Hostkey/Fingerprint

© Red Hat, Inc. and others.