PR#23: Add some logging when we fail to create a release in PDC - fedora-infra/toddlers

Pierre-Yves Chibon • 3 years ago

593ee3a

tests/plugins/test_pdc_import_compose.py

file modified

+4 -1

		`@@ -836,6 +836,7 @@`
		`pdc = MagicMock()`
		`resp = Mock()`
		`resp.status_code = 500`
		`+ resp.text = "html content"`
		`pdc["releases"]["release-id"]._.side_effect = beanbag.bbexcept.BeanBagException(`
		`msg="Failed to do something", response=resp`
		`)`
		`@@ -843,9 +844,11 @@`
		`toddlers.plugins.pdc_import_compose.ensure_release_exists(`
		`pdc, "release-id", {"foo": "bar"}`
		`)`
		`- assert caplog.records[-1].message.startswith(`
		`+ assert caplog.records[-3].message.startswith(`
		`"Failed to check if the release release-id exists: Failed to do something - response:"`
		`)`
		`+ assert caplog.records[-2].message.startswith("Failed to do something")`
		`+ assert caplog.records[-1].message.startswith("html content")`

		`def test_ensure_release_exists_create(self, caplog):`
		`caplog.set_level(logging.DEBUG)`

toddlers/plugins/pdc_import_compose.py

file modified

+9 -1

		`@@ -275,10 +275,18 @@`
		`except beanbag.bbexcept.BeanBagException as e:`
		`if e.response.status_code != 404:`
		`_log.error("Failed to check if the release %s exists: %s", release_id, e)`
		`+ _log.error(e.msg)`
		`+ _log.error(e.response.text)`
		`return`
		`_log.warning("No release %r exists. Creating.", release_id)`

		`release_payload = release.copy()`
		`release_payload.update({"active": True})`
		`_log.info("Creating release %r", release_payload)`
		`- pdc["releases"]._(release_payload)`
		`+ try:`
		`+ pdc["releases"]._(release_payload)`
		`+ except beanbag.bbexcept.BeanBagException as e:`
		`+ _log.error("Failed to create release with payload: %s", release_payload)`
		`+ _log.error(e.msg)`
		`+ _log.error(e.response.text)`
		`+ raise`