fedora-infra / toddlers

Clone
Source Code
GIT

#21 Fix calling the _process_single_package and _process_dist_git in pdc_retired_packages
Merged 3 years ago by pingou. Opened 3 years ago by pingou.
fix_pdc_retired  into  master

file modified
+2 -2 
@@ -46,9 +46,9 @@ 
 

          pdc = pdc_client_for_config(config)
 

  

          if message.topic.endswith("git.receive"):
 

-             PDCRetiredPackages._process_single_package(config, pdc, message)
 

+             self._process_single_package(config, pdc, message)
 

          else:
 

-             PDCRetiredPackages._process_dist_git(config, pdc)
 

+             self._process_dist_git(config, pdc)
 

  

      def _process_dist_git(self, config, pdc):
 

          """ Updates PDC retirement status from analyzing dist-git.

Since we move to actual, instanciated, object, we need to call the
methods using self. otherwise, it won't work as expected.

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

Metadata Update from @nphilipp:
- Request assigned
3 years ago

Looks good to me!

Hmm, now why do the tests not catch it...?

Because 100% coverage doesn't mean you're testing the integration of the different methods together...

Build succeeded.

  • tox : SUCCESS in 3m 47s

going to merge it as is to unblock toddlers in openshift

👍

Pull-Request has been merged by pingou
3 years ago
Changes Summary 1
+2 -2
file changed
toddlers/plugins/pdc_retired_packages.py
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.