#19 Fix flake8, black
Merged 4 years ago by pingou. Opened 4 years ago by nphilipp.
fedora-infra/ nphilipp/rpmautospec master--setup-py  into  master

@@ -1,7 +1,7 @@ 

+ from glob import glob

  import os

  import re

  

- from glob import glob

  

  from koji.plugin import callback

  

file modified
+1 -1
@@ -1,5 +1,5 @@ 

- import re

  from functools import cmp_to_key

+ import re

  from typing import List

  from typing import Optional

  from typing import Tuple

file modified
+4 -2
@@ -66,8 +66,10 @@ 

  

  

  def holistic_heuristic_calculate_release(

-     dist: str, evr: typing.Tuple[int, str, str],

-     lower_bound: dict, higher_bound: typing.Optional[dict],

+     dist: str,

+     evr: typing.Tuple[int, str, str],

+     lower_bound: dict,

+     higher_bound: typing.Optional[dict],

  ):

  

      # So what package EVR are we going for again? Default to "same as lower bound".

file modified
+1 -1
@@ -5,5 +5,5 @@ 

  #ignore =

  

  # Configure flake8-import-order

- application-import-names = rpmautospec

+ application-import-names = rpmautospec,koji_plugin

  import-order-style = google

file modified
+1 -1
@@ -39,5 +39,5 @@ 

      zip_safe=False,

      install_requires=INSTALL_REQUIRES,

      tests_require=TESTS_REQUIRE,

-     entry_points={"console_scripts": ["rpmautospec = rpmautospec.cli:main",],},

That was quite some comas in there :)

+     entry_points={"console_scripts": ["rpmautospec = rpmautospec.cli:main"]},

  )

When packaged as an RPM, the Koji Python package doesn't come with the
necessary Python metadata.

Black reformatted setup.py in a way which flake8 didn't like. Some other files were missing, too.

NB: I'm not 100% sure this is the right way to do it, perhaps we should patch this out when building the RPM? Because you can "pip install koji" which comes with the necessary metadata files.

Build failed.

rebased onto 6cb30f4f18b0c634fc6b8a06a7d94deb5c7f0882

4 years ago

Reusing this for the formatting snag introduced in #18.

Build failed.

rebased onto 1619354

4 years ago

Build succeeded.

That was quite some comas in there :)

Nice and easy :thumbsup:

Pull-Request has been merged by pingou

4 years ago