fedora-infra / rpmautospec

Clone

#247 RFE: generate-changelog should bump release even when spec file can’t be parsed
Closed: Fixed 2 years ago by nphilipp. Opened 2 years ago by zbyszek.

Closed: Fixed
Reopen Issue

From https://pagure.io/fedora-infra/rpmautospec/issue/228#comment-793667:

$ ~/python/rpmautospec/run-rpmautospec.py generate-changelog|grep '^\*'|head -n3
* Fri Apr 22 2022 Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> 0.11-14
* Fri Jan 21 2022 Fedora Release Engineering <releng@fedoraproject.org> - 0.11-29
* Fri Jul 23 2021 Fedora Release Engineering <releng@fedoraproject.org> - 0.11-28

generate-changelog knows that something is wrong here. It should warn.

[Hmm, editing tags saves unfinished comments, that’s awkward.]

OK, following up from #228:

  • The issue in rtkit is because the spec file can't be parsed across several commits and the fix for #228 doesn’t bump the release for these.
  • Actually, rpmautospec doesn’t “know” that the release went down from 29 to 14: the changelog entries up to 0.11-29 are contained in the changelog file whose contents are included verbatim and not parsed or processed in another way. But fixing this for real should make this unnecessary anyway.
Edited 2 years ago by nphilipp

Metadata Update from @nphilipp:
- Issue tagged with: Bug, Needs Deployment, Release Bumping Functionality
2 years ago

Metadata Update from @nphilipp:
- Issue assigned to nphilipp
2 years ago

Metadata Update from @nphilipp:
- Issue set to the milestone: 0.3
- Issue tagged with: Documentation
2 years ago

Commit abf7a1c fixes this issue

Login to comment on this ticket.

Metadata

Release Bumping Functionality Bug Needs Deployment Documentation

None
None
None
Related Pull Requests
  • #257 Merged 2 years ago
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.