#170 Trips over unset %__python macro
Closed 2 years ago by scoady. Opened 2 years ago by nphilipp.

In the python-arrow pkg repository in staging, some old changelog entries are generated with version None, i.e. the version can't be parsed out of the spec file:

nils@makake:~/dist-git/stg/fedora/rpms/python-arrow (rawhide)> rpmautospec generate-changelog .
...
* Wed Sep 16 2015 Ralph Bean <rbean@redhat.com> None-15
- 0.6.0

* Wed Sep 16 2015 Ralph Bean <rbean@redhat.com> None-14
- RPMAUTOSPEC: unresolvable merge

This is because it uses plain %__python and doesn't set it to a specific version of the interpreter:

nils@makake:~/dist-git/stg/fedora/rpms/python-arrow ((HEAD detached at a7d5e7e))> rpm --specfile *.spec
error: attempt to use unversioned python, define %__python to /usr/bin/python2 or /usr/bin/python3 explicitly
error: query of specfile python-arrow.spec failed, can't parse
nils@makake:~/dist-git/stg/fedora/rpms/python-arrow ((HEAD detached at a7d5e7e))> git grep __python
python-arrow.spec:%{__python} setup.py build
python-arrow.spec:%{__python3} setup.py build
python-arrow.spec:%{__python3} setup.py install -O1 --skip-build --root=%{buildroot}
python-arrow.spec:%{__python} setup.py install -O1 --skip-build --root=%{buildroot}
python-arrow.spec:%{__python3} setup.py test
python-arrow.spec:%{__python} setup.py test
nils@makake:~/dist-git/stg/fedora/rpms/python-arrow ((HEAD detached at a7d5e7e))>

We might want to have rpmautospec define this if missing (maybe carry a macros.workarounds file to be used with rpm --load …/macros.workarounds --specfile …) to better cope with this.


Metadata Update from @nphilipp:
- Issue tagged with: Bugs, F35 Change

2 years ago

Metadata Update from @scoady:
- Issue assigned to scoady

2 years ago

Metadata Update from @nphilipp:
- Issue tagged with: Nice to Have

2 years ago

Issue status updated to: Closed (was: Open)

2 years ago

Login to comment on this ticket.

Metadata
Boards 1
Delivery Board Status: Done
Related Pull Requests
  • #186 Merged 2 years ago