#123 Get rid of GIT tagging
Closed: Fixed 3 years ago by dkirwan. Opened 3 years ago by nphilipp.

User Story

As developers of rpmautospec,

we want to get rid of GIT tagging code,

because we don't want to familiarize with code that will be removed anyway.

Acceptance Criteria

  • The hub plugin koji_plugins/rpmautospec_hub.py is gone. The RPM spec file is updated accordingly (i.e. the sub package is removed and a suitable Obsoletes: directive is in place so the package can be seamlessly updated).
  • The tag-package subcommand (rpmautospec/tag_package.py) is gone.
  • The tagging code itself (rpmautospec/py2compat/tagging.py) is gone.
  • Unit tests for the removed code are gone.
  • Running the CLI tool rpmautospec without subcommand shows toplevel online help without throwing an exception.
  • Unit tests that cover other parts of the code (e.g. rpmautospec/changelog.py, rpmautospec/process_distgit.py) that start to fail due to the removal are marked as "expected to fail", i.e. with the @pytest.mark.xfail decorator and an explanatory comment.

Background

FeSCO asked us to go with a simpler release bumping algorithm than the previous prototype implemented, which looked at historical builds to decide on the new release number and stored information about historical builds in GIT tags to have it available locally, in Koji, etc.

The hub plugin for Koji implemented the part where successful builds got git-tagged, so it can go away. As this is the piece that (previously) had to be compatible with Python 2.x (because the hub still ran on EL7 a year ago), removing it and the supporting rpmautospec/py2compat/tagging.py module will cover #124.


Metadata Update from @nphilipp:
- Issue tagged with: F35 Change

3 years ago

Metadata Update from @dkirwan:
- Issue assigned to dkirwan

3 years ago

Metadata Update from @nphilipp:
- Issue unmarked as depending on: #124

3 years ago

Metadata Update from @dkirwan:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

3 years ago

Metadata Update from @amoloney:
- Issue set to the milestone: 0.2 (Stg Deployment)
- Issue tagged with: Cutting the Cruft

2 years ago

Login to comment on this ticket.

Metadata
Boards 1
Delivery Board Status: Done