#117 rpmautospec generate-changelog always uses LATEST as version
Closed: Fixed 2 years ago by zbyszek. Opened 3 years ago by zbyszek.

In a checkout of systemd repo:

$ rpmautospec generate-changelog $PWD
* Wed Mar 24 2021 Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> - LATEST
- A few more patches
- Revert patch that seems to cause problems with dns resolution
...
* Thu Apr 11 2019 Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> - LATEST
- Call cat /etc/machine-id just once in %%post scriptlet
...

"LATEST" seems wrong... Maybe I'm missing something obvious, but I would expect version strings there.


rpmautospec-0.1.3-5.fc34.noarch

Metadata Update from @amoloney:
- Issue assigned to dkirwan
- Issue tagged with: Bugs

3 years ago

Did you run rpmautospec tag-package first?

I didn't!

So, let's try that:

$ rpmautospec tag-package $PWD
Command `git tag --force build/systemd-0-248-2.fc35 58e2c63a03eee3a4517ce03b454e75c4f7ea4458` return code: `128`
stdout:
-------
b''
stderr:
-------
b"fatal: cannot update ref 'refs/tags/build/systemd-0-248-2.fc35': trying to write ref 'refs/tags/build/systemd-0-248-2.fc35' with nonexistent object 58e2c63a03eee3a4517ce03b454e75c4f7ea4458\n"
Error while tagging 58e2c63a03eee3a4517ce03b454e75c4f7ea4458 with build/systemd-0-248-2.fc35:
Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/rpmautospec/tag_package.py", line 137, in tag_package
    run_command(command, cwd=repopath)
  File "/usr/lib/python3.9/site-packages/rpmautospec/misc.py", line 127, in run_command
    output = subprocess.check_output(command, cwd=cwd, stderr=subprocess.PIPE)
  File "/usr/lib64/python3.9/subprocess.py", line 424, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib64/python3.9/subprocess.py", line 528, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['git', 'tag', '--force', 'build/systemd-0-248-2.fc35', '58e2c63a03eee3a4517ce03b454e75c4f7ea4458']' returned non-zero exit status 128.
Command `git tag --force build/systemd-0-248-2.fc34 97102a82f5868bf314aa09b23b9301f244bea1ab` return code: `128`
stdout:
-------
b''
stderr:
-------
b"fatal: cannot update ref 'refs/tags/build/systemd-0-248-2.fc34': trying to write ref 'refs/tags/build/systemd-0-248-2.fc34' with nonexistent object 97102a82f5868bf314aa09b23b9301f244bea1ab\n"
Error while tagging 97102a82f5868bf314aa09b23b9301f244bea1ab with build/systemd-0-248-2.fc34:
Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/rpmautospec/tag_package.py", line 137, in tag_package
    run_command(command, cwd=repopath)
  File "/usr/lib/python3.9/site-packages/rpmautospec/misc.py", line 127, in run_command
    output = subprocess.check_output(command, cwd=cwd, stderr=subprocess.PIPE)
  File "/usr/lib64/python3.9/subprocess.py", line 424, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib64/python3.9/subprocess.py", line 528, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['git', 'tag', '--force', 'build/systemd-0-248-2.fc34', '97102a82f5868bf314aa09b23b9301f244bea1ab']' returned non-zero exit status 128.
Command `git tag --force build/systemd-0-248-2.eln110 58e2c63a03eee3a4517ce03b454e75c4f7ea4458` return code: `128`
stdout:
-------
b''
stderr:
-------
b"fatal: cannot update ref 'refs/tags/build/systemd-0-248-2.eln110': trying to write ref 'refs/tags/build/systemd-0-248-2.eln110' with nonexistent object 58e2c63a03eee3a4517ce03b454e75c4f7ea4458\n"
Error while tagging 58e2c63a03eee3a4517ce03b454e75c4f7ea4458 with build/systemd-0-248-2.eln110:
Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/rpmautospec/tag_package.py", line 137, in tag_package
    run_command(command, cwd=repopath)
  File "/usr/lib/python3.9/site-packages/rpmautospec/misc.py", line 127, in run_command
    output = subprocess.check_output(command, cwd=cwd, stderr=subprocess.PIPE)
  File "/usr/lib64/python3.9/subprocess.py", line 424, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib64/python3.9/subprocess.py", line 528, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['git', 'tag', '--force', 'build/systemd-0-248-2.eln110', '58e2c63a03eee3a4517ce03b454e75c4f7ea4458']' returned non-zero exit status 128.
Tagged commit 8a86f313c74f149df70bb07d92d3dbe69e3825da as build/systemd-0-247.3-1.eln109
Tagged commit 3e123da08e601f6171dfe5a780e816c8221d36b9 as build/systemd-0-247.2-1.eln108
Tagged commit 0a51c274d6b8e1b36208bb682e1f5db9b50ade2f as build/systemd-0-247.1-3.eln107
Tagged commit 97a60859120d1c6357a6cb7dfda11c09174af1c0 as build/systemd-0-247.1-1.eln105
Tagged commit 2299ee202aea9f525bbe2c2f760294921418ec6c as build/systemd-0-246.13-1.fc33
Tagged commit 283a994776e089f12953fb061ddcb64d66c1db0f as build/systemd-0-246.6-3.eln103
Tagged commit 0a8016423048bc7c55379ceb8885f3d7b264f0ff as build/systemd-0-245.9-1.fc32
Tagged commit 6eb8bcde288dda39b163e87ee0926f6f30fcad73 as build/systemd-0-245.6-3.eln102
Tagged commit ec562b227214cfc55a5f96fe83182405b61d080c as build/systemd-0-245.6-2.eln101
Tagged commit 265d91aff516c0e0a13da9ed7613cd0cbfba9e9c as build/systemd-0-245.5-2.eln100.0
Tagged commit 54dfd2376d0c4a68ce4c45773ee767fe63afae1a as build/systemd-0-243.9-1.fc31
Tagged commit c6c2f51fd121f686fe607033d3edf4aae214dd84 as build/systemd-0-241-14.git18dd3fb.fc30
Tagged commit 66042a8cf11c0a3c9ef9eccc41ed8a8fac06aab1 as build/systemd-0-239-14.git33ccd62.fc29
Tagged commit 2f8aae2204e513d5d43d7df5ce83e6b65a401324 as build/systemd-0-238-12.git07f8cd5.fc28
Tagged commit f1095c6021d84c1d053310b0b22ed3b867ce2c76 as build/systemd-0-234-11.git5f8984e.fc27
Tagged commit a10ddf58e62667a9981d4f6faae740c629d9cd23 as build/systemd-0-233-7.fc26
Tagged commit e71765083735954c25c5453d806fe2aaf1c7e7ea as build/systemd-0-231-19.fc25
Tagged commit cfc4155361288a57ace53d1fb9b35fd4166c671c as build/systemd-0-229-22.fc24
Tagged commit 91e73e19d9261287eca18d0a1509b1fa9ebd1d80 as build/systemd-0-222-17.fc23
Tagged commit 64fd902160d11adb68814c8994c6c5d0cc9d73fb as build/systemd-0-219-28.fc22
Tagged commit b564b7c601ab340734bcc28391dc8cebac8aa1fe as build/systemd-0-216-25.fc21
Tagged commit 6244884c3a67dbacf6dcf73242e69595bf9557bd as build/systemd-0-208-31.fc20
Tagged commit b7f33dca9e89e52089b512de61cd4cff4b78d66f as build/systemd-0-204-21.fc19
Tagged commit 46a556fc69aaa9ecdfccf20f40b252ff3eed2d29 as build/systemd-0-201-2.fc18.9
Tagged commit 0ae26f6d841adaec76776c2ee2a288f4a5104803 as build/systemd-0-44-24.fc17
Tagged commit 57bf936f9bab8823f7181345f94e24779c875fec as build/systemd-0-37-25.fc16
Tagged commit 356933198d8a863a95ab2bb73cef39c57ef929dc as build/systemd-0-26-18.fc15
Tagged commit 0a66126cd37665533651cd773ea77463cddbc1ef as build/systemd-0-10-2.fc14.1
$ rpmautospec generate-changelog $PWD
* Thu Mar 25 2021 Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> - LATEST
- A few more patches
- Revert patch that seems to cause problems with dns resolution
- TEST

* Sat Mar 20 2021 Adam Williamson <awilliam@redhat.com> - LATEST
- Disable resolved cache via config snippet (#1940715)

* Thu Mar 18 2021 Yu Watanabe <yuwatana@redhat.com> - LATEST
- Version 248-rc4
- Disable epoll2_pwait2() for 32bit archs
- Drop #pragma message from patch
- Disable epoll_pwait2() in sd-event

* Tue Mar 16 2021 Adam Williamson <awilliam@redhat.com> - LATEST
- Backport PR #19009 to fix CNAME redirect resolving some more (#1933433)

* Thu Mar 11 2021 Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> - LATEST
- Backport one patch for beta freeze exception
- Add work-around for crash during upgrades
- Version 248-rc3
- Patch to fix tests on i686 and arm32

* Sat Mar 06 2021 Adam Williamson <awilliam@redhat.com> - LATEST
- Backport PR #18892 to fix stub resolver CNAME chain resolving (#1933433)

* Mon Mar 01 2021 Josh Boyer <jwboyer@fedoraproject.org> - LATEST
- Don't set the fallback hostname to "fedora" on non-Fedora OSes

* Tue Feb 23 2021 Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> - LATEST
- Use %%version_no_tilde instead of custom macro
- Version 248-rc1
- Restore trigger freshness check
- Bump release
- Version 248-rc2

* Thu Feb 18 2021 Michel Alexandre Salim <salimma@fedoraproject.org> - LATEST
- Increase oomd user memory pressure limit to 10%% (#1929856)

* Tue Feb 16 2021 Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> - LATEST
- Rename trigger to appease rpm

* Tue Feb 16 2021 Michel Alexandre Salim <salimma@fedoraproject.org> - LATEST
- Add `%%triggerun` to call systemctl preset for systemd-oomd

* Thu Feb 11 2021 Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> - LATEST
- Rework %%post/%%postun scriptlets

* Thu Feb 11 2021 Anita Zhang <the.anitazha@gmail.com> - LATEST
- Create systemd-oom user in %%pre
- Bump to 247.3-2 for systemd-oomd finishes and systemd-oomd-defaults
  subpackage

* Tue Feb 02 2021 Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> - 247.3-1.eln109
- Reorder patch to separate downstream-only patches
- Restore patches that were removed by mistake
- Merge repeated systemctl invocations in scriptlets
- Version 247.3

* Wed Jan 27 2021 Fedora Release Engineering <releng@fedoraproject.org> - 247.3-1.eln109
- - Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild

* Tue Jan 26 2021 Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> - 247.3-1.eln109
- Make lto opt-out work again
- Fix bfq patch again
- Remove systemd-networkd recommendation in eln builds

Partial success ;(

Hi @zbyszek after speaking with @nphilipp in the coming weeks we're planning to make changes which may resolve this issue you are experiencing. We'd like to keep this ticket open to track the issue until it has been resolved.

Looks as if #158—implementing changelog generation without git tags—solves this one as well.

Metadata Update from @nphilipp:
- Issue assigned to nphilipp (was: dkirwan)

2 years ago

This seems to be resolved now.

Metadata Update from @zbyszek:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

2 years ago

Login to comment on this ticket.

Metadata