PR#10: Fix for tickets waiting on reviewer info not being reset - fedora-infra/review_stats

fedora-infra / review_stats

#10 Fix for tickets waiting on reviewer info not being reset

Merged 3 years ago by mattia. Opened 3 years ago by mattia.

Unknown source needinfo_reviewer into master

Bump bugfix version

Mattia Verga • 3 years ago

717e1af

Fix stale tickets due to needinfo from submitter

Mattia Verga • 3 years ago

51b4f77

review_stats/__init__.py

file modified

+1 -1

		`@@ -27,7 +27,7 @@`

		`import logging as python_logging`

		`- __version__ = '6.0.2'`
		`+ __version__ = '6.0.3'`

		`# Some magic bug numbers`
		`ACCEPT = 163779`

review_stats/models.py

file modified

+12 -1

		`@@ -115,7 +115,8 @@`
		`def hidden(self):`
		`"""A quick bool for mark the ticket as hidden."""`
		`return (not self.dependencies_on_qa or self.dead_review or self.fail_build or`
		`- self.legal_issues or self.needinfo or self.not_ready or self.stalled)`
		`+ self.legal_issues or self.needinfo or self.needinfo_reviewer or`
		`+ self.not_ready or self.stalled)`

		`@property`
		`def last_modified(self):`
		`@@ -141,6 +142,16 @@`
		`return False`

		`@property`
		`+ def needinfo_reviewer(self):`
		`+ """A flag for tickets waiting for reviewer response."""`
		`+ for flag in self.bug.flags:`
		`+ if (flag['name'] == 'needinfo'`
		`+ and flag['status'] == '?'`
		`+ and flag['requestee'] == self.bug.assigned_to):`
		`+ return True`
		`+ return False`
		`+`
		`+ @property`
		`def needsponsor(self):`
		`"""A flag for tickets in need of a sponsor."""`
		`if NEEDSPONSOR in self.bug.blocks:`

review_stats/templates/hidden.html

file modified

		`@@ -35,6 +35,7 @@`
		`{% if ticket.fail_build %}Fails to build<br/>{% endif %}`
		`{% if ticket.legal_issues %}Legal Issues<br/>{% endif %}`
		`{% if ticket.needinfo %}Needinfo from submitter<br/>{% endif %}`
		`+ {% if ticket.needinfo_reviewer %}Needinfo from reviewer<br/>{% endif %}`
		`{% if ticket.not_ready %}Marked NotReady<br/>{% endif %}`
		`{% if ticket.stalled %}Marked Stalled<br/>{% endif %}`
		`</td>`

review_stats/utils.py

file modified

+5 -4

		`@@ -168,17 +168,18 @@`
		`output = []`
		`for tk in tklist:`
		`user_email = tk.bug.creator if user == 'submitter' else tk.bug.assigned_to`
		`- if not tk.needinfo:`
		`+ if user == 'submitter' and not tk.needinfo:`
		`+ continue`
		`+ if user == 'reviewer' and not tk.needinfo_reviewer:`
		`continue`
		`for flag in tk.bug.flags:`
		`if ('name' in flag and flag['name'] == 'needinfo'`
		`- and flag['status'] == '?'):`
		`+ and flag['status'] == '?' and flag['requestee'] == user_email):`
		`date_set = flag['modification_date']`
		`req_user = flag['requestee']`
		`break`
		`if date_set < date_limit:`
		`- if req_user == user_email:`
		`- output.append(tk)`
		`+ output.append(tk)`

		`return sorted(output, key=lambda b: b.bug.id)`

mattia commented 3 years ago

Tickets with NEEDINFO set against reviewer were not counted as "hidden", moreover we currently not reset their state after the 30 days waiting period.