PR#3: fix infofasjson get_user_attrs returning None - fedora-infra/ipsilon-fedora

fedora-infra / ipsilon-fedora

#3 fix infofasjson get_user_attrs returning None

Merged 3 years ago by abompard. Opened 3 years ago by ryanlerch.

fedora-infra/ ryanlerch/ipsilon-fedora staging-infofasjson into staging

fix infofasjson get_user_attrs returning None

Ryan Lerch • 3 years ago

191f2f0

ipsilon/info/infofasjson.py

file modified

+1 -1

		`@@ -48,7 +48,7 @@`
		`user_agreements_data = client.list_user_agreements(username=user).result`
		`except Exception as e:`
		`self.error(f'FASJSON error: {e}')`
		`- return`
		`+ return {}`

		`# assumption that first email is the default`
		`user_data['email'] = user_data['emails'][0]`

ryanlerch commented 3 years ago

Previously if using the fasjson info plugin, and the fasjson client
returned an error, we were returning None. However, we need to return an
empty dict, otherwise login/common.py in ipsilon would raise an error.

Signed-off-by: Ryan Lerch rlerch@redhat.com