PR#126: Small syntax fixes - fedora-infra/arc

fedora-infra / arc

#126 Small syntax fixes

Merged 2 years ago by zlopez. Opened 2 years ago by zlopez.

fedora-infra/ zlopez/arc fix_syntax into main

Small syntax fixes

Michal Konecny • 2 years ago

3877bc4

docs/dist-git-move/copr.rst

file modified

+11 -9

		`@@ -17,24 +17,26 @@`

		`- COPR is using API calls for flagging dist-git commits or pull requests in`
		`build_logic.py module <https://github.com/fedora-copr/copr/blob/2789f06b36be5c13eae83c8695eb36de03a7728f/frontend/coprs_frontend/coprs/logic/builds_logic.py#L1101-L1109>`_.
		- It is calling `/api/0/<package_name>/pull-request/<pr_id>/flag` and
		- `/api/0/<package_name>/c/<commit_id>/flag` API endpoints.
		+ It is calling ``/api/0/<package_name>/pull-request/<pr_id>/flag`` and
		+ ``/api/0/<package_name>/c/<commit_id>/flag`` API endpoints.

		`CLI client`
		`^^^^`

		- - COPR is doing `git clone` from dist-git, which is wrapped in
		- `copr-distgit-client clone --dist-git fedora <pkgname>`.
		+ - COPR is doing ``git clone`` from dist-git, which is wrapped in
		+ ``copr-distgit-client clone --dist-git fedora <pkgname>``.

		`Fedora messaging`
		`^^^^`

		`- COPR is listening to following dist-git topics:`
		- * `org.fedoraproject.prod.pagure.git.receive`
		- * `org.fedoraproject.prod.pagure.pull-request.new`
		- * `org.fedoraproject.prod.pagure.pull-request.rebased`
		- * `org.fedoraproject.prod.pagure.pull-request.updated`
		- * `org.fedoraproject.prod.pagure.pull-request.comment.added`
		`+`
		+ * ``org.fedoraproject.prod.pagure.git.receive``
		+ * ``org.fedoraproject.prod.pagure.pull-request.new``
		+ * ``org.fedoraproject.prod.pagure.pull-request.rebased``
		+ * ``org.fedoraproject.prod.pagure.pull-request.updated``
		+ * ``org.fedoraproject.prod.pagure.pull-request.comment.added``
		`+`
		`- These topics are configured in`
		`frontend messaging configuration <https://pagure.io/fedora-infra/ansible/blob/main/f/roles/copr/frontend/templates/fedora-messaging/copr_messaging.toml>`_.

docs/dist-git-move/hotness.rst

file modified

+4 -4

		`@@ -12,9 +12,9 @@`
		`Validations`
		`^^^^`

		- - Checking the monitoring setting by calling dist-git `_dg/anitya/rpms/<package_name>` API in
		+ - Checking the monitoring setting by calling dist-git ``_dg/anitya/rpms/<package_name>`` API in
		`pagure module <https://github.com/fedora-infra/the-new-hotness/blob/master/hotness/validators/pagure.py>`_
		- - Checking the retirement status by HTTP GET request for `dead.package` in
		+ - Checking the retirement status by HTTP GET request for ``dead.package`` in
		`pagure module <https://github.com/fedora-infra/the-new-hotness/blob/master/hotness/validators/pagure.py>`_

		`Scratch builds`
		`@@ -29,7 +29,7 @@`

		`In order to switch out Pagure Dist Git for an alternative that provides a`
		`relatively compatible API pattern, the following changes must be made in the`
		`- placed mentioned below.`
		`+ places mentioned below.`

		`Necessary`
		`^^^^`
		`@@ -43,7 +43,7 @@`

		`- As hotness is mostly using just plain HTTP, git interactions with dist-git it's not necessary`
		`to change much. Only the monitoring settings needs to be provided somewhere.`
		- - Change the default value for `dist_git_url` in
		+ - Change the default value for ``dist_git_url`` in
		`config module <https://github.com/fedora-infra/the-new-hotness/blob/master/hotness/config.py>`_.
		`As this could be set in configuration it's not necessary to do that, but it would be nice to`
		`change it to new git forge.`

docs/dist-git-move/toddlers.rst

file modified

+19 -18

		`@@ -26,53 +26,54 @@`
		- This `module <https://pagure.io/fedora-infra/toddlers/blob/main/f/toddlers/utils/pagure.py>`_
		`contains method interacting with pagure or dist-git`
		`- Few methods are specific only for dist-git:`
		- * `set_monitoring_status`
		- * `is_project_orphaned`
		- * `assign_maintainer_to_project`
		`+`
		+ * ``set_monitoring_status``
		+ * ``is_project_orphaned``
		+ * ``assign_maintainer_to_project``

		`clean_retired_packages toddler`
		`^^^^`

		- - `/_dg/orphan` API endpoint called in `orphan_package` method
		- - `/_dg/bzoverrides` API endpoint called in `orphan_package` method
		- - `/<namespace>/<name>/git/modifyacls` API endpoint called in `remove_access` method
		- - `/<namespace>/<name>/watchers/update` API endpoint called in `remove_access` method
		+ - ``/_dg/orphan`` API endpoint called in ``orphan_package`` method
		+ - ``/_dg/bzoverrides`` API endpoint called in ``orphan_package`` method
		+ - ``/<namespace>/<name>/git/modifyacls`` API endpoint called in ``remove_access`` method
		+ - ``/<namespace>/<name>/watchers/update`` API endpoint called in ``remove_access`` method

		`distgit_bugzilla_sync toddler`
		`^^^^`

		- - `/extras/pagure_poc.json` called in `_get_pagure_projects`
		- - `/extras/pagure_bz.json` called in `_get_pagure_projects`
		+ - ``/extras/pagure_poc.json`` called in ``_get_pagure_projects``
		+ - ``/extras/pagure_bz.json`` called in ``_get_pagure_projects``

		`flag_ci_pr toddler`
		`^^^^`

		`- Listening to following topics:`
		- * `org.centos.*.ci.dist-git-pr.test.error`
		- * `org.centos.*.ci.dist-git-pr.test.complete`
		- * `org.centos.*.ci.dist-git-pr.test.running`
		- - `/api/0/<namespace>/<repo>/c/<commit_hash>/flag` called in `process` method
		+ * ``org.centos.*.ci.dist-git-pr.test.error``
		+ * ``org.centos.*.ci.dist-git-pr.test.complete``
		+ * ``org.centos.*.ci.dist-git-pr.test.running``
		+ - ``/api/0/<namespace>/<repo>/c/<commit_hash>/flag`` called in ``process`` method

		`flag_commit_build toddler`
		`^^^^`

		- - `/api/0/<namespace>/<repo>/c/<commit_hash>/flag` called in `process` method
		+ - ``/api/0/<namespace>/<repo>/c/<commit_hash>/flag`` called in ``process`` method

		`packagers_without_bugzilla toddler`
		`^^^^`

		- - `/extras/pagure_bz.json` called in `get_user_and_groups_dist_git` method
		+ - ``/extras/pagure_bz.json`` called in ``get_user_and_groups_dist_git`` method

		`pdc_retired_packages toddler`
		`^^^^`

		- - `/<namespace>/<repo>/raw/<branch>/f/dead.package` called in `_is_retired_in_dist_git` method
		+ - ``/<namespace>/<repo>/raw/<branch>/f/dead.package`` called in ``_is_retired_in_dist_git`` method

		`pdc_unretire_packages toddler`
		`^^^^`

		- - `/<namespace>/<package_name>.git` called in `process_ticket` method
		- - `git clone` called in `process_ticket` toddler
		+ - ``/<namespace>/<package_name>.git`` called in ``process_ticket`` method
		+ - ``git clone`` called in ``process_ticket`` toddler

		`Changes proposed`
		`----`