PR#98: robosignatory: coreos: only set key in config for staging - fedora-infra/ansible

fedora-infra / ansible

#98 robosignatory: coreos: only set key in config for staging

Merged 3 years ago by mohanboddu. Opened 3 years ago by dustymabe.

fedora-infra/ dustymabe/ansible dusty-change-robosig-config into master

robosignatory: coreos: only set key in config for staging

Dusty Mabe • 3 years ago

8a3e99a

roles/robosignatory/templates/robosignatory.toml.j2

file modified

+5 -1

		`@@ -504,7 +504,11 @@`

		`[consumer_config.coreos]`
		`bucket = "fcos-builds"`
		`- key = "{{ (env == 'production')\|ternary('fedora-32', 'testkey') }}"`
		`+ {% if env == "staging" %}`
		`+ # Set key to 'testkey' because in staging we only have one key and`
		`+ # detecting which key to use based on FCOS version numbers won't work.`
		`+ key = "testkey"`
		`+ {% endif %}`

		`[consumer_config.coreos.aws]`
		`access_key = "{{ fcos_builds_releng_aws_access_id }}"`

dustymabe commented 3 years ago

Upstream robosignatory was changed to auto-detect the key to use
for signing for Fedora CoreOS builds in the following PR:
https://pagure.io/robosignatory/pull-request/46#

Let's switch to only setting the key in the config for the staging
environment so that we can start using the auto-detection.

dustymabe commented 3 years ago

/hold

This requires https://pagure.io/robosignatory/pull-request/46#

zuul commented 3 years ago

Build succeeded.

ansible-review-diff : SUCCESS in 1m 20s

rebased onto e18473ca1f83236d6afe3af3fb9019856a9f9127

3 years ago

zuul commented 3 years ago

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.