No commits found
I'm not 100% sure that this works as intended, therefore WIP.
6 new commits added
Fix some problems found by ansible-review.
Zuul: Compartmentalize ansible-review crashes
Zuul: Filter initial warnings of ansible-review
Zuul: Run ansible-review on the changes in the PR
Zuul: Rename job and split out shared actions
Add basic zuul configuration to run ansible-review
recheck
Build failed.
Zuul: Run ansible-review on changes in PRs
We are hitting this https://opendev.org/zuul/zuul/src/branch/master/zuul/executor/server.py#L1595 I raised this to discussion on #zuul. I'll keep you updated.
1 new commit added
WIP: DO NOT MERGE
7 new commits added
Unable to freeze job graph: Job ansible-review-base does not specify a run playbook
It's odd, because if I run findPlaybook() in a (mock-fed) AnsibleJob, for any of the (Zuul) playbooks, it returns what I would expect.
findPlaybook()
AnsibleJob
Also, I'm poking at things right now, if you want to see what we're trying to get working, drop the "WIP: DO NOT MERGE" commit.
Merge Failed.
This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
rebased onto 89039cdbb4223383eebf5467f7f22c0138c68ed1
8 new commits added
Build succeeded.
@fbo BTW: This ^^ indicates that Zuul uses outdated configuration, as the current tip of the PR (commit 7fc07c39f7b6b2fffcc739ed2af9f028d3c8ade3) doesn't contain, nor references ci/ping.yaml. I'll repush to get it to pick up the current one.
ci/ping.yaml
This one should be running ansible-review-diff, i.e. it's not a fluke.
ansible-review-diff
Hmm, recheck doesn't help.
rebased onto 60ef1b3e87c7e7fc6a48bf42c2e8f3f474e46987
rebased onto 12dba3e
Zuul encountered a syntax error while parsing its configuration in the repo fedora-infra/ansible on branch master. The error was:
Job ansible-review-base in fedora-infra/ansible is not permitted to shadow job ansible-review-base in fedora-zuul-jobs
The error appears in the following job stanza:
job: name: ansible-review-base pre-run: ci/ansible-review-base.yaml
in "fedora-infra/ansible/.zuul.yaml@master", line 2, column 3
This is rebased on top of #60, and will have to stay WIP until softwarefactory-project.io runs Zuul 3.18 (which contains the fix for the errors above). Then we can move the jobs out of fedora-zuul-jobs again.
Pull-Request has been closed by smooge
I'm not 100% sure that this works as intended, therefore WIP.