aa73555
@@ -115,5 +115,5 @@
# TTL: 10 days (in miliseconds)
message_ttl: 864000000
routing_keys:
- - "org.fedoraproject.{{ env_suffix }}.gitlab-centos.#"
+ - "org.centos.{{ env_suffix }}.gitlab.#"
# CENTOS GITLAB END
\ No newline at end of file
This PR changes both the source and category for the centos gitlab topic.
I will also need someone to run it for me :-)
org.centos directly? That would be consistent with the other notifications sent by the centos infra
Aren't others used for testing/development only?
nope, the messages sent by centos-ci are all: org.centos.{prod,stage}...
An example: https://apps.fedoraproject.org/datagrepper/id?id=2020-255ec4db-7951-4e1b-81cc-7378c7ea15fe&is_raw=true&size=extra-large
org.centos is correct, I was misremembering the earlier prefixes
org.centos
rebased onto 40a8e94e25fd2a65c1962916dcfb2b39a48b8c61
Just updated it to org.centos.{{ env_suffix }}.gitlab.#.
org.centos.{{ env_suffix }}.gitlab.#
I was going to say that I would keep gitlab-centos, but I realize that if there ever is a gitlab instance in fedora, it'll be prefixed by org.fedoraproject...
On the other side, keeping 'gitlab-centos' will make it be the category which isn't taking into account the prefix (so if we have org.fedoraproject.prod.gitlab and org.centos.prod.gitlab, both gitlab instances would show when filtering messages in datagrepper for category = gitlab).
Has anyone thoughts on this?
I think it should be fine to just call it 'gitlab'... if we have things that filter and break, we should fix them. :)
I switched it to gitlab because org.centos.prod.gitlab-centos... didn't feel right since it is already "namespaced" in "org.centos..".
gitlab
org.centos.prod.gitlab-centos...
Would it be possible to filter "by source" as well in datanommer?
Not atm but that might be a worthwhile requirement for its replacement :)
Since there is a consensus, I'm going to rebase and merge this.
Do you want me to run the playbook to have the queue created on the rabbitmq server?
rebased onto aa73555
Pull-Request has been merged by pingou
Yes, please :)
This PR changes both the source and category for the centos gitlab topic.
I will also need someone to run it for me :-)