#278 post-receive-fedora-messaging: Don't attempt to decode unicode strings
Merged 3 years ago by pingou. Opened 3 years ago by churchyard.
fedora-infra/ churchyard/ansible no_decode_strings  into  master

@@ -51,7 +51,7 @@ 

      if proc.returncode != 0:

          raise IOError('git rev-list failed: %r, err: %r' % (stdout, stderr))

  

-     for line in stdout.decode('utf-8').strip().split('\n'):

+     for line in stdout.strip().split('\n'):

          yield line.strip()

  

  

On Python 3, we can only decode byte sequences.

subprocess.Popen(universal_newlines=True) always returns unicode stdout/sderr.

Fixes https://pagure.io/fedora-infrastructure/issue/9366

Pull-Request has been merged by pingou

3 years ago
Metadata