PR#241: Hotfix pagure to disable all email notification for the 389-ds-base project - fedora-infra/ansible

Pierre-Yves Chibon • 3 years ago

ffe3cf2

Pierre-Yves Chibon • 3 years ago

043d2c7

roles/pagure/frontend/files/notify.py

file added

+1180

The added file is too large to be shown here, see it at: roles/pagure/frontend/files/notify.py

roles/pagure/frontend/tasks/main.yml

file modified

+12

		`@@ -508,6 +508,18 @@`
		`- pagure`


		`+ # Install hotfix for the notify.py file for`
		`+ # https://pagure.io/fedora-infrastructure/issue/9309`
		`+`
		`+ - name: Install the hotfixed notify.py`
		`+ copy: src=notify.py`
		`+ dest=/usr/lib/python3.6/site-packages/pagure/lib/notify.py`
		`+ owner=root group=root mode=0644`
		`+ notify: restart httpd`
		`+ tags:`
		`+ - hotfix`
		`+ - pagure`
		`+`
		`# Ensure all the services are up and running`

		`- name: Start and enable httpd, postfix, pagure_milter`

no initial comment

This is a Freeze Break Request

Build succeeded.

+1 here.

I glanced over the notify.py file, other than that LGTM +1

@mohanboddu There are two commits, the first one is the original file, the second is the diff/fix/change :)

+1 looks good

2 new commits added

pagure: hotfix notify.py so it doesn't send any emails for the 389-ds-base project, at all
pagure: Add to the repo the notify.py file from pagure 5.11.2

3 years ago

I have added a _log.info("Do not notify about 389-ds-base") to the previous patch so we log that we are not sending emails.

@spichugi tested it briefly today, with success.

I'll merge the PR and apply the hotfix tomorrow (we're working on figuring out when it needs to be deployed)

Metadata Update from @pingou:
- Pull-request tagged with: freeze-break-request

3 years ago

We have agreed that I will merge and apply this around 19:00 UTC tonight.

Alright, let's do it!

Thanks for the reviews!