Build succeeded.

• fi-ansible--ansible-review-diff : SUCCESS in 2m 14s

If you could use the correct routing key from the start it would be helpful. IIRC, changing the routing key here in the future won't unsubscribe the old one, which then needs to be cleaned up manually. Cleaning it up manually is not a big deal, but it's something to keep in mind as otherwise we end up wondering why the queue is growing unexpectedly.

Also, you can add monitoring to the queue size, so it alerts when the queue reaches certain thresholds.

@james Are you happy with this routing key name or shall we change it ?

Build succeeded.

• fi-ansible--ansible-review-diff : SUCCESS in 2m 08s

I discussed this pull request with @james last week and he was fine with it.

Also, you can add monitoring to the queue size, so it alerts when the queue reaches certain thresholds.

I see these values in for thresholds in default configs:

 thresholds:
   warning:  10000
   critical: 100000

I am fine with these values (unless you want them to be tweaked).

10K messages in the queue before triggering a monitoring warning seems a little high, don't you think?

10K messages in the queue before triggering a monitoring warning seems a little high, don't you think?

I tried to fix it with last commit. Does it look ok ?

Build succeeded.

• fi-ansible--ansible-review-diff : SUCCESS in 2m 39s

Looks good to me. Shall I merge and run the playbook?

Build succeeded.

• fi-ansible--ansible-review-diff : SUCCESS in 2m 35s

Looks good to me. Shall I merge and run the playbook?

Yes, please! Let us know when these changes are applied to servers.

On it! :)