PR#227: Freeze Break Request: bodhi / base: change wsgi to only use 1 thread and more processes - fedora-infra/ansible

fedora-infra / ansible

#227 Freeze Break Request: bodhi / base: change wsgi to only use 1 thread and more processes

Closed 3 years ago by kevin. Opened 3 years ago by kevin.

Unknown source bodhi-threads-to-one into master

bodhi / base: change wsgi to only use 1 thread and more processes

Kevin Fenzi • 3 years ago

aed3d47

roles/bodhi2/base/templates/httpd.conf.j2

file modified

+1 -1

		`@@ -61,7 +61,7 @@`
		`{% else %}`
		`Alias /static/v{{ bodhi_version.split('-')[0] }} /usr/lib/python3.8/site-packages/bodhi/server/static/`
		`{% endif %}`
		`- WSGIDaemonProcess bodhi display-name=bodhi processes=2 threads=2 maximum-requests=500 home=/httpdir request-timeout=90`
		`+ WSGIDaemonProcess bodhi display-name=bodhi processes=4 threads=1 maximum-requests=500 home=/httpdir request-timeout=90`
		`WSGIApplicationGroup %{GLOBAL}`
		`WSGISocketPrefix run/wsgi`
		`WSGIRestrictStdout Off`

kevin commented 3 years ago

We are hitting odd db errors in bodhi frontend pods.
See: https://pagure.io/fedora-infrastructure/issue/9234
It was suggested there to try moving threads down to 1 to avoid any
possible threading concurrency issues. So this does that.
It needs to be merged, then bodhi openshift playbook run and a new
build/deployment rolled out.

Signed-off-by: Kevin Fenzi kevin@scrye.com

zuul commented 3 years ago

Build succeeded.

fi-ansible--ansible-review-diff : SUCCESS in 2m 16s

smooge commented 3 years ago

pingou commented 3 years ago

+1 worth a try and easy to revert

adamwill commented 3 years ago

I think this may actually not be necessary - before doing this @kevin "just scaled it to 1 pod instead of 2" and that seems to be helping, in my checks. I tried some stuff that used to fail quite often, a lot of times, and it hasn't failed yet.

Pull-Request has been closed by kevin

3 years ago