fixes releng issue #11999

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/3c8ee3617be64a68a90783adcc3377db

• fi-ansible-lint-diff : SUCCESS in 4m 30s
• fi-yamllint-diff : SUCCESS in 2m 32s

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/8012e85ea8fe499c8bdafe1986db6603

• fi-ansible-lint-diff : SUCCESS in 4m 08s
• fi-yamllint-diff : SUCCESS in 2m 31s

The https:// part is in both the SERVER variable, and down below in the --repofrompath argument. That will result in it being doubled up, i.e. https://https://composes.stream.centos.org. Removing it from the SERVER variable would match the centos-9s-sync script.

I think we should just use a directory of centos-10 (drop the -stream suffix) for simplicity.

A couple of points on these for loops:

• There is no i386 repo to sync, so we can remove that.
• As-is this won't work because the i variable will get overwritten in the inner loop. You have to use a different variable like j. I would recommend using more descriptive variables, like basearch and repo.
• It's unnecessary to use the echo command substitution because you can just pass the strings to the for loop, e.g. for repo in BaseOS AppStream CRB.

We will need to reference the basearch and repo directories separately in the URL. If we set those variables in the for loops as described above, the last two flags should be --repofrompath=$repo,https://$SERVER/$TOPDIR/$repo/$basearch/os/ --enablerepo=$repo.

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/074b86c52c9741f4bbf695b1a884b90d

• fi-ansible-lint-diff : SUCCESS in 4m 33s
• fi-yamllint-diff : SUCCESS in 2m 41s

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/f918b784009b424086516253e19f0481

• fi-ansible-lint-diff : SUCCESS in 4m 19s
• fi-yamllint-diff : SUCCESS in 3m 12s

@carlwgeorge Should be all set now

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/1577e86eaf614271a92ad88a5003b7e3

• fi-ansible-lint-diff : SUCCESS in 3m 56s
• fi-yamllint-diff : SUCCESS in 2m 49s

This has a small syntax error I missed in my first review of this. It's missing the do.

Similar to the missing do in the outer for loop, the inner for loop is missing a done.

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/e9330ab8f777473b90e4fa3714e682da

• fi-ansible-lint-diff : SUCCESS in 5m 48s
• fi-yamllint-diff : SUCCESS in 4m 22s

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/8285609b713248f4862b9f74be4769c9

• fi-ansible-lint-diff : SUCCESS in 4m 03s
• fi-yamllint-diff : SUCCESS in 2m 43s

LGTM, thanks for making those adjustments.

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/1d2de46417e342f6a47e7d32021105ae

• fi-ansible-lint-diff : SUCCESS in 4m 10s
• fi-yamllint-diff : SUCCESS in 2m 22s

This looks just fine... I do wonder about dropping the -stream name tho. Won't that confuse people and make them think this is some kind of weird centos linux 10?
We do sync centos linux 8 without the stream name (and with for stream 8), so dropping the stream seems confusing to me.

Thoughts?

I do wonder about dropping the -stream name tho. Won't that confuse people and make them think this is some kind of weird centos linux 10?

That was a change I asked @jrichardson to make. Since there is only one distro from the CentOS project with version number 10, I don't think it would be confusing. Anyone looking this closely at the infrastructure implementation details will know that the official distro name is still "CentOS Stream 10". I regularly see people online refer to "CentOS 9" as shorthand for "CentOS Stream 9", because there is only one distro from the CentOS Project with version number 9.

We do sync centos linux 8 without the stream name (and with for stream 8), so dropping the stream seems confusing to me.

We don't sync CentOS Linux 8 anymore. I could see the confusion if we were trying to repurpose the centos-8 directory for CentOS Stream 8, but that's not being suggested. As an aside, if we were going to be 100% consistent, the centos-8 sync directory should have been named centos-linux-8.

Really what you've uncovered here is me inching closer to my secret plan to eventually drop the Stream suffix officially, similar to how Fedora dropped it's Core suffix. The whole reason we came up with the Stream suffix is because we needed to differentiate between two variants of version 8, the classic downstream rebuild and the new upstream model that can accept contributions. That need no longer exists, so longer term my goal is to get rid of the useless suffix. For now I'm happy to just encode the name in fewer places when it isn't necessary.

Since it's just the local directory name, I don't think it makes too much difference either way, but dropping the -stream would be my preference.

ok, fair enough.

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/ca30a0a942df45e1aad277db54634180

• fi-ansible-lint-diff : SUCCESS in 4m 26s
• fi-yamllint-diff : SUCCESS in 2m 49s

So, I set it up and ran it... and it ran ok, but didn't do what was intended.

centos-10:
AppStream
BaseOS
CRB

centos-10/AppStream:
Packages
repodata

centos-10/AppStream/Packages:
389-ds-base-3.0.1-2.el10.aarch64.rpm
389-ds-base-3.0.1-2.el10.ppc64le.rpm
389-ds-base-3.0.1-2.el10.s390x.rpm
389-ds-base-3.0.1-2.el10.x86_64.rpm

ie, it's just putting them all in Packages/ under the repos, not split by arches.

I think you need to use -a and make some more dirs... happy to provide more info. :)