PR#187: email aliases: Refactor/add several Fedora Council email addresses - fedora-infra/ansible

fedora-infra / ansible

#187 email aliases: Refactor/add several Fedora Council email addresses

Merged 3 years ago by jflory7. Opened 3 years ago by jflory7.

fedora-infra/ jflory7/ansible update/email-aliases into master

email aliases: Refactor/add several Fedora Council email addresses

Justin W. Flory • 3 years ago

392e0e8

roles/fas_client/files/aliases.template

file modified

+15 -5

		`@@ -148,13 +148,23 @@`
		`directors: board`

		`## Fedora Project Leader (FPL)`
		`- ## https://docs.fedoraproject.org/fedora-project/council/fpl.html`
		`+ ## https://docs.fedoraproject.org/en-US/council/fpl/`
		`chair: mattdm`

		`## Fedora Community Action and Impact Coordinator`
		`- ## https://docs.fedoraproject.org/fedora-project/council/fcaic.html`
		`+ ## https://docs.fedoraproject.org/en-US/council/fcaic/`
		`fcaic: riecatnor`

		`+ ## Fedora Program Manager`
		`+ ## https://docs.fedoraproject.org/en-US/council/fpgm/`
		`+ fpgm: bcotton`
		`+ program-manager: fpgm`
		`+`
		`+ ## Fedora Diversity Advisor`
		`+ ## https://docs.fedoraproject.org/en-US/council/diversity-advisor/`
		`+ diversity: fpl,fcaic,jflory7`
		`+ diversity-inclusion: diversity`
		`+`
		`# FESCo`
		`fesco-chair: kevin`
		`fesco: fesco@lists.fedoraproject.org`
		`@@ -170,10 +180,10 @@`
		`fudcon-register: flock-admin`
		`fudcon-paper: flock-admin`

		`- # Fudcon regional aliases - point to point person before that fudcon`
		`+ # Fudcon regional aliases - point to point person before that fudcon`
		`fudcon-emea: flock-admin`
		`- # fudcon-apac:`
		`- # fudcon-na:`
		`+ # fudcon-apac:`
		`+ # fudcon-na:`
		`fudcon-latam: flock-admin`

		`# flock`

jflory7 commented 3 years ago

This commit refactors/updates several of the Fedora Council email
aliases used in the Fedora Council docs and also across the project.
Summary of changes:

Update fcaic@fp.o from @bex to @riecatnor
Add fpgm@fp.o to @bcotton (somehow there was not one already?)
Add diversity@fp.o to @jflory7, @mattdm, @riecatnor
Fix broken docs links in comments

This will also give me a point-of-contact address to link on the
Diversity Advisor docs page, which was my original intent in proposing
these changes:

https://docs.fedoraproject.org/en-US/council/diversity-advisor/#contact

zuul commented 3 years ago

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

rebased onto 7372a4d8dd082c63fba1c0df9d35582f993f5677

3 years ago

zuul commented 3 years ago

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

jflory7 commented 3 years ago

Sooo, my new branch was 1073 commits behind master which is why this failed. Had to update my workflow with Pagure a bit from cgit. Turns out @riecatnor was already updated with the FCAIC alias. But the rest of the changes still apply.

@zuul is showing this failed, but the Pagure shows the PR as mergeable. I fixed the conflicts. Let me know if there is anything I need to do to prep this for merge.

pingou commented on line 22 of roles/fas_client/files/aliases.template 3 years ago

Left over from a conflict apparently :)

1 new commit added

Remove git merge conflict line spotted by @pingou

3 years ago

rebased onto 1f432f1ac25edc5d548e3e77004393d99f93513d

3 years ago

rebased onto 1f432f1ac25edc5d548e3e77004393d99f93513d

3 years ago

jflory7 commented 3 years ago

Whoops! Good catch, refixed my last commit and removed the merge conflict diff. Should be good to go now.

zuul commented 3 years ago

Build succeeded.

fi-ansible--ansible-review-diff : SUCCESS in 1m 59s

rebased onto 3980eb23c11fd3b38d2359b34d6446faa50cc39d

3 years ago

zuul commented 3 years ago

Build succeeded.

fi-ansible--ansible-review-diff : SUCCESS in 1m 58s

till commented on line 16 of roles/fas_client/files/aliases.template 3 years ago

IMHO it would be nicer to avoid using acronyms here and use program-manager instead. This would also be more inclusive for newcomers, see for example the arguments at https://blog.prototypr.io/reasons-to-avoid-using-acronyms-e1a97c8ea6c4

bcotton commented 3 years ago

IMHO it would be nicer to avoid using acronyms here and use program-manager instead.

Aliases are cheap, why not have both?

rebased onto 39fb9e49e06ab03fef9586c612584ad28328fea8

3 years ago

rebased onto 24289b9892f50f7a073d5c88dab2bded1cdac6d3

3 years ago

jflory7 commented 3 years ago

@till @bcotton Great point. I updated the PR so it will include fpgm@fp.o and program-manager@fp.o. Once the CI finishes, I will merge this into master.