PR#177: koji_hub: allow update/remove for sidetag owners - fedora-infra/ansible

fedora-infra / ansible

#177 koji_hub: allow update/remove for sidetag owners

Merged 3 years ago by kevin. Opened 3 years ago by dustymabe.

fedora-infra/ dustymabe/ansible dusty-update-hub-policy into master

koji_hub: allow update/remove for sidetag owners

Dusty Mabe • 3 years ago

6432297

roles/koji_hub/templates/hub.conf.j2

file modified

+1 -1

		`@@ -179,7 +179,7 @@`
		`# CoreOS coreos-pool and coreos-release tags, https://pagure.io/releng/issue/8294`
		`tag coreos-pool coreos-release && has_perm coreos-continuous && match action add unblock block :: allow`
		`# Allow people to manage their side tags, https://pagure.io/releng/issue/9229`
		`- is_sidetag_owner && match action add unblock block :: allow`
		`+ is_sidetag_owner && match action add update remove unblock block :: allow`
		`# Catch-all rule.`
		`all :: deny`

dustymabe commented 3 years ago

https://pagure.io/releng/issue/9229#comment-667272

zuul commented 3 years ago

Build succeeded.

fi-ansible--ansible-review-diff : SUCCESS in 2m 00s

rebased onto 773dcfe6c89effa3ae7ad45c6a5ca70d0aaf543a

3 years ago

rebased onto 773dcfe6c89effa3ae7ad45c6a5ca70d0aaf543a

3 years ago

zuul commented 3 years ago

Build succeeded.

fi-ansible--ansible-review-diff : SUCCESS in 2m 15s

rebased onto 6432297

3 years ago

rebased onto 6432297

3 years ago

Pull-Request has been merged by kevin

3 years ago

zuul commented 3 years ago

Build succeeded.

fi-ansible--ansible-review-diff : SUCCESS in 2m 43s

dustymabe commented 3 years ago

do we need to run a playbook to apply this?

kevin commented 3 years ago

Yes, and I did already.

ignatenkobrain commented 3 years ago

Just thinking if we can just drop match statement and just allow people to do anything with the package list in their sidetags... Which we actually do now :)

kevin commented 3 years ago

We could... it's kinda nice to have it all spelled out tho.