PR#1374: Add cron job to enact FESCo SIG Policy - fedora-infra/ansible

fedora-infra / ansible

#1374 Add cron job to enact FESCo SIG Policy

Merged a year ago by zlopez. Opened a year ago by patrikp.

fedora-infra/ patrikp/ansible main into main

Add cron job to enact FESCo SIG Policy

Patrik Polakovič • a year ago

7714377

roles/releng/tasks/main.yml

file modified

		`@@ -133,6 +133,7 @@`
		`- fedora-messaging # needed by pungi to emit fedora-messages.`
		`- python3-bugzilla # needed by ftbfs scrips/cron.`
		`- fedora-repo-zdicts # needed for pungi to make zchunk repodata`
		+ - fedrq # needed by `sig_policy` script
		`tags:`
		`- releng`

		`@@ -205,6 +206,12 @@`
		`copy: src="rawhide-iot" dest=/etc/cron.d/rawhide-iot`
		`when: inventory_hostname.startswith('compose-iot-01.iad2')`

		`+ # put cron job in for enforcing FESCo SIG Policy`
		`+ # https://docs.fedoraproject.org/en-US/fesco/SIG_policy/`
		`+ - name: sig_policy cron`
		`+ template: src="sig_policy.j2" dest=/etc/cron.d/sig_policy`
		`+ when: inventory_hostname.startswith('compose-x86-01.iad2')`
		`+`
		`- name: Create /etc/pki/fedora-messaging`
		`file:`
		`dest: /etc/pki/fedora-messaging`

roles/releng/templates/sig_policy.j2

file added

		`@@ -0,0 +1,4 @@`
		+ # Runs the `sig_policy.py` script
		`+ MAILTO=releng-cron@lists.fedoraproject.org`
		`+ PAGURE_API_TOKEN={{ fesco-sig-policy-src-token }}`
gotmax23 commented a year ago The variable name should change to something with underscores (e.g. `{{ fesco_sig_policy_src_token }}`) and that needs to be defined in the ansible-private repo like @kevin said.
		+ 30 9 * * 1 root TMPDIR=`mktemp -d /tmp/sig_policy` && chmod 755 $TMPDIR && cd $TMPDIR && git clone https://pagure.io/releng.git && cd releng/scripts/fesco/sig-policy && python sig_policy.py

patrikp commented a year ago

Signed-off-by: Patrik Polakovič patrik@alphamail.org

zuul commented a year ago

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/1af11b3b703f44b6a9a0daa210b5c36a

fi-ansible-lint-diff : SUCCESS in 5m 18s
fi-yamllint-diff : SUCCESS in 3m 21s

kevin commented a year ago

Thanks for working on this!

2 items:

Can we wait until after freeze for this? I don't think it's to urgent and we unfreeze wed. ;)
We need to pass this script a api token that has perms to do the work here. I guess best would be to move to this being a template and using 'PAGURE_API_TOKEN={{ fesco-sig-policy-src-token }}' and then someone in main can setup that token in the ansible-private repo.

rebased onto af4f550baeb4c2a877a1c562f7aacc62424b4bcd

a year ago

zuul commented a year ago

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/f9d05f03031e4a5889948be20781c771

fi-ansible-lint-diff : SUCCESS in 5m 15s
fi-yamllint-diff : SUCCESS in 3m 16s

gotmax23 commented a year ago

This script requires fedrq to be installed.

rebased onto df85ad5849d3b8c10a5aba126a1f1ed79820d97f

a year ago

zuul commented a year ago

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/a4a80bb8eb5f4bc7ba1fa535c975d467

fi-ansible-lint-diff : SUCCESS in 5m 03s
fi-yamllint-diff : SUCCESS in 3m 21s

zlopez commented a year ago

@patrikp Are you still working on this or it is now ready for merge?

patrikp commented a year ago

I think it's done. If you feel that way as well feel free to merge.

rebased onto 7714377

a year ago

zuul commented a year ago

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/b40eae137ccb4ef4961f715dada1966e

fi-ansible-lint-diff : SUCCESS in 5m 37s
fi-yamllint-diff : SUCCESS in 3m 28s

Pull-Request has been merged by zlopez

a year ago

zlopez commented a year ago

I merged this and tried to deploy it, but it failed with following error:

The full traceback is:                                                                                                                                                                                                                        
Traceback (most recent call last):                                                                                                                                                                                                            
  File "/usr/lib/python3.9/site-packages/ansible/template/__init__.py", line 1128, in do_template                                                                                                                                             
    res = self.environment.concat(rf)                                                                                                                                                                                                         
  File "/usr/lib/python3.9/site-packages/ansible/template/native_helpers.py", line 88, in ansible_concat                                                                                                                                      
    return ''.join([to_text(v) for v in nodes])                                                                                                                                                                                               
  File "/usr/lib/python3.9/site-packages/ansible/template/native_helpers.py", line 88, in <listcomp>                                                                                                                                          
    return ''.join([to_text(v) for v in nodes])                                                                                                                                                                                               
  File "<template>", line 17, in root                                                                                                                                                                                                         
  File "/usr/lib/python3.9/site-packages/ansible/_vendor/jinja2/runtime.py", line 852, in _fail_with_undefined_error                                                                                                                          
    raise self._undefined_exception(self._undefined_message)                                                                                                                                                                                  
jinja2.exceptions.UndefinedError: 'fesco' is undefined                                                                                                                                                                                        

During handling of the above exception, another exception occurred:                                                                                                                                                                           

Traceback (most recent call last):                                                                                                                                                                                                            
  File "/usr/lib/python3.9/site-packages/ansible/plugins/action/template.py", line 138, in run                                                                                                                                                
    resultant = templar.do_template(template_data, preserve_trailing_newlines=True, escape_backslashes=False)                                                                                                                                 
  File "/usr/lib/python3.9/site-packages/ansible/template/__init__.py", line 1162, in do_template                                                                                                                                             
    raise AnsibleUndefinedVariable(e)                                                                                                                                                                                                         
ansible.errors.AnsibleUndefinedVariable: 'fesco' is undefined                                                                                                                                                                                 
fatal: [compose-x86-01.iad2.fedoraproject.org]: FAILED! => {                                                                                                                                                                                  
    "changed": false,                                                                                                                                                                                                                         
    "msg": "AnsibleUndefinedVariable: 'fesco' is undefined"                                                                                                                                                                                   
}

Edited a year ago by zlopez

gotmax23 commented on line 4 of roles/releng/templates/sig_policy.j2 a year ago

The variable name should change to something with underscores (e.g. {{ fesco_sig_policy_src_token }}) and that needs to be defined in the ansible-private repo like @kevin said.