fedora-infra / ansible

Clone
Source Code
GIT

#1195 distgit: Enable email notifications on new commits
Closed 2 years ago by kevin. Opened 2 years ago by gotmax23.
fedora-infra/ gotmax23/ansible watchcommits  into  main

file modified
+1 -1 
@@ -56,7 +56,7 @@ 
 

  LOCAL_SSH_KEY = False
 

  {% endif %}
 

  ALLOW_DELETE_BRANCH = False
 

- EMAIL_ON_WATCHCOMMITS = False
 

+ EMAIL_ON_WATCHCOMMITS = True
 

  GIT_HOOK_DB_RO = True
 

  LOG_ALL_COMMITS = True
 

  ALWAYS_FEDMSG_ON_COMMITS = True

Currently, when users select "Watch Commits" or "Watch Issues, PRs, and
Commits" for a distgit repository, they don't get any commit
notifications.

Build succeeded.

Because this is supposed to be handled by FMN today, not pagure itself

FMN doesn't recognize users such as myself who don't have an account in the old FAS2 instance. Even for users who do, FMN still doesn't work well. I propose re-enabling this until the new FMN is finished.

rebased onto bd32833
2 years ago

Build succeeded.

@gotmax23 We are currently trying to deploy a new version of FMN in staging and it seems it finally started to work. Hopefully this could solve this problem.

@gotmax23 We are currently trying to deploy a new version of FMN in staging and it seems it finally started to work. Hopefully this could solve this problem.

So that is still the old codebase, but it now works with the new accounts system?

It is, but we did some changes. I think it's now using fasjson instead fedora accounts library, which should work with new account system.

Pull-Request has been closed by kevin
2 years ago
Metadata
None
No Tags
Changes Summary 1
+1 -1
file changed
roles/distgit/pagure/templates/pagure_shared.cfg
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.