#593 Feed: smaller 'details' link
Merged 6 years ago by abompard. Opened 6 years ago by abompard.
abompard/fedora-hubs fix/feed-details  into  develop

@@ -52,9 +52,14 @@ 

            { (this.props.item.msg_ids &&

               Object.keys(this.props.item.msg_ids).length > 1) &&

              <div className="mt-auto">

-               <small>

-                 <button className="btn btn-link p-0" onClick={this.toggleDetails}>details</button>

-               </small>

+               <button

+                 className="btn btn-sm btn-link p-0"

+                 onClick={this.toggleDetails}

+                 >

+                 <small>

+                   details

Do we need this in a <small> still, now we are using a btn-sm class?

I think this doesnt make the actual button any smaller, just the text -- and seems to mess with the button padding too because the text is smaller...

+                 </small>

+               </button>

              </div>

            }

          </div>

I find the "details" link a bit too visible, this makes it smaller. What do you think @ryanlerch?

Do we need this in a <small> still, now we are using a btn-sm class?

I think this doesnt make the actual button any smaller, just the text -- and seems to mess with the button padding too because the text is smaller...

other than that one comment, :thumbsup: looks good to me!

The padding should have been set to 0 anyway, and the btn-link class makes only the text visible, so adding small does make it a tiny bit smaller. But if you prefer I can leave out the small, it's not much of a change anyway.

ah -- missed the btn-link! /me just tested on an existing button yeah. Let's leave the small then!

:D

Commit 53a561e fixes this pull-request

Pull-Request has been merged by abompard

6 years ago

Pull-Request has been merged by abompard

6 years ago
Metadata