PR#577: tidy up the library widget - fedora-hubs

fedora-hubs

#577 tidy up the library widget

Merged 6 years ago by abompard. Opened 6 years ago by ryanlerch.

ryanlerch/fedora-hubs tidy-library into develop

Ryan Lerch • 6 years ago

6667e2c

file modified

		`@@ -26,6 +26,12 @@`
		`)]`
		`is_react = True`
		`views_module = ".views"`
		`+ description = {`
		`+ "stream": "Bookmark links for display on your stream",`
		`+ "user": "Bookmark links for display on your hub",`
		`+ "team": ("Bookmark links for display on the team's "`
		`+ "hub"),`
		`+ }`

		`def get_props(self, instance, args, *kwargs):`
		`props = super(Library, self).get_props(instance, args, *kwargs)`

js/app/widgets/library/Link.js

file modified

+18 -17

		`@@ -15,17 +15,31 @@`
		`alt=""`
		`/>`
		`</div>`
		- <div className={`media-body ${this.props.showDropdown ? "pr-3" : ""}`}>
		`- { this.props.showDropdown &&`
		+ <div className={`media-body align-self-center`}>
		`+ <a`
		`+ href={this.props.url}`
		`+ className="d-block"`
		`+ target="_blank"`
		`+ >`
		`+ {this.props.title}`
		`+ </a>`
		`+ <p className="mb-0 description">`
		`+ <small>`
		`+ {this.props.description}`
		`+ </small>`
		`+ </p>`
		`+ </div>`
		`+ { this.props.showDropdown &&`
		`<div`
		`- className="dropdown"`
		`+ className="dropdown align-self-center"`
		`>`
		`<button`
		`- className="btn btn-link text-secondary dropdown-toggle"`
		`+ className="btn btn-link text-secondary"`
		`data-toggle="dropdown"`
		`aria-haspopup="true"`
		`aria-expanded="false"`
		`>`
		`+ <i className="fa fa-cog"></i>`
		`</button>`
		`<div`
		`className="dropdown-menu dropdown-menu-right"`
		`@@ -46,19 +60,6 @@`
		`</div>`
		`</div>`
		`}`
		`- <a`
		`- href={this.props.url}`
		`- className="d-block"`
		`- target="_blank"`
		`- >`
		`- {this.props.title}`
		`- </a>`
		`- <p className="mb-0 description">`
		`- <small>`
		`- {this.props.description}`
		`- </small>`
		`- </p>`
		`- </div>`
		`</li>`
		`);`
		`}`

js/app/widgets/library/Widget.js

file modified

+4 -3

		`@@ -198,16 +198,17 @@`
		`}`
		`</div>`
		`:`
		`- <p className="text-secondary">`
		`- <em>No links yet.</em>`
		`+ <p className="text-secondary text-center">`
		`+ <em>No items in this Library yet.</em>`
		`</p>`
		`}`
		`{this.props.hub.perms.config &&`
		`<div>`
		`<div className="text-center">`
		`<button`
		`- className="btn btn-secondary btn-sm"`
		`+ className="btn btn-outline-secondary btn-block btn-sm"`
		`onClick={this.onAddDialogOpen}`
		`+ title="add new link to library"`
		`>`
		`Add a New Item`
		`</button>`

js/app/widgets/library/library.css

file modified

+5 -6

		`@@ -1,5 +1,5 @@`
		`.widget-library div.link-preview {`
		`- max-width: 25%;`
		`+ max-width: 72px;`
		`}`
		`.widget-library img.link-preview {`
		`width: 100%;`
		`@@ -11,11 +11,10 @@`
		`border-bottom: 1px solid #eee;`
		`}`

		`- .widget-library .Link .dropdown {`
		`- position: absolute;`
		`- right: .5em;`
		`- }`
		`-`
		`.widget-library .Link .description {`
		`line-height: 1;`
		`}`
		`+`
		`+ .widget-library .btn{`
		`+ cursor: pointer;`
abompard commented 6 years ago Is this really necessary? I don't see where you're applying the `btn` class to anything but a `button` or a `a` element, and those already change the cursor to a pointer, don't they?
		`+ }`

no initial comment

rebased onto 41d64cd

6 years ago

abompard commented on line 22 of js/app/widgets/library/library.css 6 years ago

Is this really necessary? I don't see where you're applying the btn class to anything but a button or a a element, and those already change the cursor to a pointer, don't they?