From 0fc58ce6f60102a695a3ce47194c28434c3ef9a7 Mon Sep 17 00:00:00 2001
From: Aurélien Bompard <aurelien@bompard.org>
Date: Feb 05 2018 17:49:12 +0000
Subject: Lint the Javascript


---

diff --git a/hubs/static/client/.eslintrc.json b/hubs/static/client/.eslintrc.json
index 2fe5df5..4c81f2d 100644
--- a/hubs/static/client/.eslintrc.json
+++ b/hubs/static/client/.eslintrc.json
@@ -1,20 +1,10 @@
 {
-  "parser": "babel-eslint",
   "env": {
     "browser": true,
-    "node": true,
     "jquery": true
   },
-  "plugins": [
-    "react"
-  ],
-  "rules": {
-    "react/prop-types": "off"
+  "globals": {
+    "__webpack_public_path__": true
   },
-  "parserOptions": {
-    "ecmaFeatures": {
-      "jsx": true
-    }
-  },
-  "extends": ["plugin:react/recommended"]
+  "extends": "react-app"
 }
diff --git a/hubs/static/client/app/components/AddWidget/WidgetSelectDialog.js b/hubs/static/client/app/components/AddWidget/WidgetSelectDialog.js
index dae41ec..2b48a6f 100644
--- a/hubs/static/client/app/components/AddWidget/WidgetSelectDialog.js
+++ b/hubs/static/client/app/components/AddWidget/WidgetSelectDialog.js
@@ -1,6 +1,5 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-import { connect } from 'react-redux';
 import VisibilitySelect from '../VisibilitySelect';
 
 
diff --git a/hubs/static/client/app/components/AddWidget/index.js b/hubs/static/client/app/components/AddWidget/index.js
index 18c3455..b83c07f 100644
--- a/hubs/static/client/app/components/AddWidget/index.js
+++ b/hubs/static/client/app/components/AddWidget/index.js
@@ -3,7 +3,6 @@ import {
   defineMessages,
   FormattedMessage,
   } from 'react-intl';
-import PropTypes from 'prop-types';
 import AddWidgetDialog from './AddWidgetDialog';
 
 
diff --git a/hubs/static/client/app/components/AllGroupsPage.js b/hubs/static/client/app/components/AllGroupsPage.js
index 9ccdd32..ac55060 100644
--- a/hubs/static/client/app/components/AllGroupsPage.js
+++ b/hubs/static/client/app/components/AllGroupsPage.js
@@ -1,10 +1,5 @@
 import React from 'react';
-import PropTypes from 'prop-types';
 import { connect } from 'react-redux';
-import {
-  defineMessages,
-  FormattedMessage,
-  } from 'react-intl';
 import PageStructure from './PageStructure';
 import { monogramColour } from '../core/utils';
 
@@ -43,6 +38,7 @@ class AllGroupsPage extends React.Component {
                                 className="avatar"
                                 src={hub.config.avatar}
                                 width='60px'
+                                alt=""
                                 />
                         }
                             <div className="text-dark align-self-center ml-3">
diff --git a/hubs/static/client/app/components/CobWeb/index.js b/hubs/static/client/app/components/CobWeb/index.js
index 4333f20..9544174 100644
--- a/hubs/static/client/app/components/CobWeb/index.js
+++ b/hubs/static/client/app/components/CobWeb/index.js
@@ -28,7 +28,10 @@ export default class CobWeb extends React.Component {
 
     return (
       <div className="CobWeb media mb-3">
-        <img className="d-flex align-self-center mr-3 square-32" src={icon} />
+        <img
+          className="d-flex align-self-center mr-3 square-32"
+          src={icon} alt=""
+          />
         <div className="media-body">
           {msg}
         </div>
diff --git a/hubs/static/client/app/components/CompletionInput.js b/hubs/static/client/app/components/CompletionInput.js
index e5b13c9..1817bb2 100644
--- a/hubs/static/client/app/components/CompletionInput.js
+++ b/hubs/static/client/app/components/CompletionInput.js
@@ -74,7 +74,7 @@ export default class CompletionInput extends React.Component {
 
   loadFromServer(value) {
     this.setState({isLoading: true});
-    this.serverRequest = $.ajax({
+    this.serverRequest = jQuery.ajax({
       url: this.props.url,
       method: 'GET',
       data: {q: value},
diff --git a/hubs/static/client/app/components/HubCommunity.js b/hubs/static/client/app/components/HubCommunity.js
index b9850d9..023b9d9 100644
--- a/hubs/static/client/app/components/HubCommunity.js
+++ b/hubs/static/client/app/components/HubCommunity.js
@@ -89,7 +89,7 @@ class HubCommunityOwners extends React.Component {
         <div className="row no-gutters">
         { owners.slice(0, ellipsis_limit).map((owner) => (
             <div className="col-sm-6 mb-2" key={owner.username}>
-              <img className="img-circle mr-2" src={owner.avatar} />
+              <img className="img-circle mr-2" src={owner.avatar} alt="" />
               <a href={owner.hub_url}>{owner.username}</a>
             </div>
           ))
@@ -118,7 +118,7 @@ class HubCommunityOwners extends React.Component {
             >
             { owners.map((owner) => (
                 <div className="col-sm-6 mb-2" key={owner.username}>
-                  <img className="img-circle img-circle-lg mr-2" src={owner.avatar} />
+                  <img className="img-circle img-circle-lg mr-2" src={owner.avatar} alt="" />
                   <a href={owner.hub_url}>{owner.username}</a>
                 </div>
               ))
diff --git a/hubs/static/client/app/components/HubConfig/HubConfig.css b/hubs/static/client/app/components/HubConfig/HubConfig.css
index 17cc35f..422a873 100644
--- a/hubs/static/client/app/components/HubConfig/HubConfig.css
+++ b/hubs/static/client/app/components/HubConfig/HubConfig.css
@@ -13,6 +13,8 @@
 }
 .HubConfigDialog .nav-tabs .nav-link {
   border: 0;
+  width: 100%;
+  text-align: right;
 }
 
 .HubConfigDialog .modal-body {
diff --git a/hubs/static/client/app/components/HubConfig/HubConfigDialog.js b/hubs/static/client/app/components/HubConfig/HubConfigDialog.js
index 88fe2d9..5e9d02c 100644
--- a/hubs/static/client/app/components/HubConfig/HubConfigDialog.js
+++ b/hubs/static/client/app/components/HubConfig/HubConfigDialog.js
@@ -3,7 +3,6 @@ import {
   defineMessages,
   FormattedMessage,
   } from 'react-intl';
-import PropTypes from 'prop-types';
 import GeneralPanel from './HubConfigPanelGeneral';
 import VCSPanel from './HubConfigPanelVCS';
 import UserPanel from './HubConfigPanelUser';
@@ -12,7 +11,6 @@ import MailingListPanel from './HubConfigPanelMailingList';
 import ChatPanel from './HubConfigPanelChat';
 import MeetingsPanel from './HubConfigPanelMeetings';
 import DevPlatformPanel from './HubConfigPanelDevPlatform';
-import NotImplementedPanel from './HubConfigPanelNotImpl';
 import Modal from '../../components/Modal';
 import TabSet from '../../components/TabSet';
 import Spinner from "../Spinner";
@@ -125,7 +123,7 @@ export default class HubConfigDialog extends React.Component {
           key="owners"
           users={this.props.users}
           globalConfig={this.props.globalConfig}
-          role="owner"
+          hubRole="owner"
           handleChange={this.props.usingFas ? null : this.props.onUserChange}
           tabTitle={<FormattedMessage {...messages.owners} />}
           urls={this.props.urls}
@@ -137,7 +135,7 @@ export default class HubConfigDialog extends React.Component {
           key="members"
           users={this.props.users}
           globalConfig={this.props.globalConfig}
-          role="member"
+          hubRole="member"
           handleChange={this.props.usingFas ? null : this.props.onUserChange}
           tabTitle={<FormattedMessage {...messages.members} />}
           urls={this.props.urls}
diff --git a/hubs/static/client/app/components/HubConfig/HubConfigPanelGeneral.js b/hubs/static/client/app/components/HubConfig/HubConfigPanelGeneral.js
index f97af47..678ffb7 100644
--- a/hubs/static/client/app/components/HubConfig/HubConfigPanelGeneral.js
+++ b/hubs/static/client/app/components/HubConfig/HubConfigPanelGeneral.js
@@ -2,7 +2,7 @@ import React from 'react';
 import {
   defineMessages,
   FormattedMessage,
-  FormattedHTMLMessage,
+  //FormattedHTMLMessage,
   } from 'react-intl';
 
 
@@ -79,7 +79,7 @@ export default class GeneralPanel extends React.Component {
 
   render() {
     const stillLoading = (typeof this.props.hubConfig.summary === "undefined");
-    const visibilities = this.props.globalConfig.hub_visibility || [];
+    //const visibilities = this.props.globalConfig.hub_visibility || [];
     const right_width = this.props.hubConfig ? 12 - this.props.hubConfig.left_width : 4;
 
     let invalid = {};
diff --git a/hubs/static/client/app/components/HubConfig/HubConfigPanelUser.js b/hubs/static/client/app/components/HubConfig/HubConfigPanelUser.js
index 6fc4107..bc78da1 100644
--- a/hubs/static/client/app/components/HubConfig/HubConfigPanelUser.js
+++ b/hubs/static/client/app/components/HubConfig/HubConfigPanelUser.js
@@ -1,6 +1,5 @@
 import React from 'react';
 import {
-  injectIntl,
   defineMessages,
   FormattedMessage,
   FormattedHTMLMessage,
@@ -76,7 +75,7 @@ export default class UserPanel extends React.Component {
 
   handleAdd(e) {
     e.preventDefault();
-    this.props.handleChange(this.state.addUser, null, this.props.role);
+    this.props.handleChange(this.state.addUser, null, this.props.hubRole);
     this.setState({addUser: null, addUserInputContents: ""});
   }
 
@@ -91,16 +90,16 @@ export default class UserPanel extends React.Component {
   filterSuggestedUsers(user) {
     // Only suggest non-members.
     return (
-      this.props.users[this.props.role].indexOf(user) === -1
+      this.props.users[this.props.hubRole].indexOf(user) === -1
       &&
-      this.props.users[`pending-${this.props.role}`].indexOf(user) === -1
+      this.props.users[`pending-${this.props.hubRole}`].indexOf(user) === -1
     );
   }
 
   render() {
-    const users = this.props.users[this.props.role].map(user => {
+    const users = this.props.users[this.props.hubRole].map(user => {
       const locked = (
-        this.props.role === "owner" &&
+        this.props.hubRole === "owner" &&
         this.props.currentUser.logged_in &&
         user.username === this.props.currentUser.nickname
       );
@@ -108,18 +107,18 @@ export default class UserPanel extends React.Component {
         <UserRow
           key={user.username}
           user={user}
-          role={this.props.role}
+          hubRole={this.props.hubRole}
           globalConfig={this.props.globalConfig}
           onChange={this.props.handleChange}
           locked={locked}
           />
       );
     });
-    const pendingUsers = this.props.users[`pending-${this.props.role}`].map(user => (
+    const pendingUsers = this.props.users[`pending-${this.props.hubRole}`].map(user => (
       <UserRow
         key={user.username}
         user={user}
-        role={`pending-${this.props.role}`}
+        hubRole={`pending-${this.props.hubRole}`}
         globalConfig={this.props.globalConfig}
         onChange={this.props.handleChange}
         />
@@ -188,7 +187,7 @@ export default class UserPanel extends React.Component {
                     }}
                     url={(
                       this.props.urls.hubConfigSuggestUsers
-                      + "?exclude-role=" + this.props.role
+                      + "?exclude-role=" + this.props.hubRole
                     )}
                     getSuggestionValue={getSuggestionValue}
                     renderSuggestion={renderSuggestion}
@@ -240,7 +239,7 @@ class UserRow extends React.Component {
 
   handleChange(e) {
     e.preventDefault();
-    this.props.onChange(this.props.user, this.props.role, e.target.value);
+    this.props.onChange(this.props.user, this.props.hubRole, e.target.value);
   }
 
   render() {
@@ -255,7 +254,7 @@ class UserRow extends React.Component {
             :
               <select
                 name={this.props.user.username}
-                value={this.props.role}
+                value={this.props.hubRole}
                 className="form-control"
                 onChange={this.handleChange}
                 >
diff --git a/hubs/static/client/app/components/HubConfig/index.js b/hubs/static/client/app/components/HubConfig/index.js
index 5491548..de9fafb 100644
--- a/hubs/static/client/app/components/HubConfig/index.js
+++ b/hubs/static/client/app/components/HubConfig/index.js
@@ -1,10 +1,9 @@
 import React from 'react';
-import PropTypes from 'prop-types';
 import { connect } from 'react-redux';
-import {
-  defineMessages,
-  FormattedMessage,
-  } from 'react-intl';
+//import {
+//  defineMessages,
+//  FormattedMessage,
+//  } from 'react-intl';
 import {
   saveHub,
   openConfigDialog,
@@ -14,12 +13,12 @@ import HubConfigDialog from './HubConfigDialog';
 import "./HubConfig.css";
 
 
-const messages = defineMessages({
-  button: {
-    id: "hubs.core.config.button",
-    defaultMessage: "Hub settings",
-  },
-});
+//const messages = defineMessages({
+//  button: {
+//    id: "hubs.core.config.button",
+//    defaultMessage: "Hub settings",
+//  },
+//});
 
 
 class HubConfig extends React.Component {
diff --git a/hubs/static/client/app/components/HubHeader/HubAvatar.js b/hubs/static/client/app/components/HubHeader/HubAvatar.js
index 076e837..5974148 100644
--- a/hubs/static/client/app/components/HubHeader/HubAvatar.js
+++ b/hubs/static/client/app/components/HubHeader/HubAvatar.js
@@ -1,5 +1,4 @@
 import React from 'react';
-import PropTypes from 'prop-types';
 import { monogramColour } from '../../core/utils';
 
 
@@ -10,6 +9,7 @@ export default class HubAvatar extends React.Component {
         <img
           className="avatar"
           src={this.props.avatar}
+          alt=""
           />
       );
     } else {
diff --git a/hubs/static/client/app/components/HubHeader/HubStats.js b/hubs/static/client/app/components/HubHeader/HubStats.js
index 016cd8b..4420cfe 100644
--- a/hubs/static/client/app/components/HubHeader/HubStats.js
+++ b/hubs/static/client/app/components/HubHeader/HubStats.js
@@ -1,13 +1,5 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-import { connect } from 'react-redux';
-import {
-  subscribe,
-  unsubscribe,
-  join,
-  leave,
-  giveUpAdmin,
-} from "../../core/actions/hub";
 import "./HubStats.css";
 
 
diff --git a/hubs/static/client/app/components/HubHeader/StreamHeaderLeft.js b/hubs/static/client/app/components/HubHeader/StreamHeaderLeft.js
index 7752228..b1b478f 100644
--- a/hubs/static/client/app/components/HubHeader/StreamHeaderLeft.js
+++ b/hubs/static/client/app/components/HubHeader/StreamHeaderLeft.js
@@ -1,5 +1,4 @@
 import React from 'react';
-import PropTypes from 'prop-types';
 
 
 export default class StreamHeaderLeft extends React.Component {
diff --git a/hubs/static/client/app/components/HubHeader/StreamHeaderRight.js b/hubs/static/client/app/components/HubHeader/StreamHeaderRight.js
index ab2a072..d1bf5e6 100644
--- a/hubs/static/client/app/components/HubHeader/StreamHeaderRight.js
+++ b/hubs/static/client/app/components/HubHeader/StreamHeaderRight.js
@@ -1,5 +1,4 @@
 import React from 'react';
-import PropTypes from 'prop-types';
 import EditModeButton from './EditModeButton';
 
 
diff --git a/hubs/static/client/app/components/HubHeader/index.js b/hubs/static/client/app/components/HubHeader/index.js
index 5841b95..cdef55a 100644
--- a/hubs/static/client/app/components/HubHeader/index.js
+++ b/hubs/static/client/app/components/HubHeader/index.js
@@ -1,5 +1,4 @@
 import React from 'react';
-import PropTypes from 'prop-types';
 import { connect } from 'react-redux';
 import Spinner from "../Spinner";
 import HubHeaderLeft from "./HubHeaderLeft";
@@ -22,11 +21,11 @@ class HubHeader extends React.Component {
       hubTypeCss = `hub-${this.props.hub.type}`;
       if (this.props.hub.type === "stream") {
         left_width = 8;
-        HeaderLeft = StreamHeaderLeft,
+        HeaderLeft = StreamHeaderLeft;
         HeaderRight = StreamHeaderRight;
       } else {
         left_width = this.props.hub.config.left_width;
-        HeaderLeft = HubHeaderLeft,
+        HeaderLeft = HubHeaderLeft;
         HeaderRight = HubHeaderRight;
       }
     }
diff --git a/hubs/static/client/app/components/HubPage.js b/hubs/static/client/app/components/HubPage.js
index 0b0b8ab..9a4ce41 100644
--- a/hubs/static/client/app/components/HubPage.js
+++ b/hubs/static/client/app/components/HubPage.js
@@ -1,10 +1,5 @@
 import React from 'react';
-import PropTypes from 'prop-types';
 import { connect } from 'react-redux';
-import {
-  defineMessages,
-  FormattedMessage,
-  } from 'react-intl';
 import PageStructure from './PageStructure';
 import WidgetsArea from './WidgetsArea';
 import HubHeader from './HubHeader';
diff --git a/hubs/static/client/app/components/NotifIcon.js b/hubs/static/client/app/components/NotifIcon.js
index 9330e99..d9b48e7 100644
--- a/hubs/static/client/app/components/NotifIcon.js
+++ b/hubs/static/client/app/components/NotifIcon.js
@@ -24,9 +24,9 @@ class NotifIcon extends React.PureComponent {
 
   changeNotifyIcon(color) {
     // Set the notify icon for 5s
-    if (color == "green") {
+    if (color === "green") {
       color = "#33ff00";
-    } else if (color == "red") {
+    } else if (color === "red") {
       color = "#eb361e";
     }
     window.Notificon(color);
diff --git a/hubs/static/client/app/components/PageStructure.js b/hubs/static/client/app/components/PageStructure.js
index 5279182..5db92ca 100644
--- a/hubs/static/client/app/components/PageStructure.js
+++ b/hubs/static/client/app/components/PageStructure.js
@@ -1,5 +1,4 @@
 import React from 'react';
-import PropTypes from 'prop-types';
 import FlashMessages from './FlashMessages';
 import Heartbeat from './Heartbeat';
 import LeftMenu from './LeftMenu';
diff --git a/hubs/static/client/app/components/SSESource.js b/hubs/static/client/app/components/SSESource.js
index 1b41d19..e17507e 100644
--- a/hubs/static/client/app/components/SSESource.js
+++ b/hubs/static/client/app/components/SSESource.js
@@ -38,7 +38,7 @@ class SSESource extends React.PureComponent {
   }
 
   setupSource() {
-    this.source = new ReconnectingEventSource(this.props.url),
+    this.source = new ReconnectingEventSource(this.props.url);
     MESSAGE_TYPES.forEach((msgType) => {
       this.source.addEventListener(msgType, (e) => {
         this.props.dispatch(sseEvent(msgType, JSON.parse(e.data)));
diff --git a/hubs/static/client/app/components/SimpleWidget.js b/hubs/static/client/app/components/SimpleWidget.js
index 5695b40..48921ec 100644
--- a/hubs/static/client/app/components/SimpleWidget.js
+++ b/hubs/static/client/app/components/SimpleWidget.js
@@ -4,7 +4,6 @@ import {
   widgetWillUpdate
   } from "../core/actions/widget";
 import { backendCall } from "../core/utils";
-import SimpleWidgetConfig from './SimpleWidgetConfig';
 import WidgetChrome from './WidgetChrome';
 
 
@@ -62,8 +61,8 @@ export default class SimpleWidget extends React.PureComponent {
     if (this.props.widget.hiddenIfEmpty) {
       if (
         this.state.isLoading ||
-        !this.props.editMode && (
-          !this.state.contents || !this.state.contents.trim()
+        (!this.props.editMode &&
+         (!this.state.contents || !this.state.contents.trim())
         )
       ) {
         // Hide when loading and when the contents is empty in view mode.
@@ -75,9 +74,9 @@ export default class SimpleWidget extends React.PureComponent {
         widget={this.props.widget}
         editMode={this.props.editMode}
         >
-        { this.state.isLoading &&
+        { this.state.isLoading ?
           <div className="p-2 text-muted">Loading...</div>
-          ||
+          :
           <div className="p-2" dangerouslySetInnerHTML={{__html: this.state.contents}} />
         }
       </WidgetChrome>
diff --git a/hubs/static/client/app/components/Spinner/index.js b/hubs/static/client/app/components/Spinner/index.js
index 28776e3..c88246d 100644
--- a/hubs/static/client/app/components/Spinner/index.js
+++ b/hubs/static/client/app/components/Spinner/index.js
@@ -18,7 +18,7 @@ export default class Spinner extends React.Component {
     }
     return (
       <div className={className}>
-        <img src={img} />
+        <img src={img} alt="loading..." />
       </div>
     );
   }
diff --git a/hubs/static/client/app/components/StreamPage.js b/hubs/static/client/app/components/StreamPage.js
index 1b54af6..8568d9b 100644
--- a/hubs/static/client/app/components/StreamPage.js
+++ b/hubs/static/client/app/components/StreamPage.js
@@ -1,10 +1,5 @@
 import React from 'react';
-import PropTypes from 'prop-types';
 import { connect } from 'react-redux';
-import {
-  defineMessages,
-  FormattedMessage,
-  } from 'react-intl';
 import PageStructure from './PageStructure';
 import HubHeader from './HubHeader';
 import WidgetsArea from './WidgetsArea';
diff --git a/hubs/static/client/app/components/Tab.js b/hubs/static/client/app/components/Tab.js
index 1084065..ee41c0c 100644
--- a/hubs/static/client/app/components/Tab.js
+++ b/hubs/static/client/app/components/Tab.js
@@ -4,16 +4,16 @@ import PropTypes from 'prop-types';
 
 export default class Tab extends React.Component {
   render() {
-    var linkClass = `nav-link ${this.props.tabLinkClass}`;
+    let linkClass = `btn btn-link nav-link ${this.props.tabLinkClass}`;
     if (this.props.active) { linkClass += " active"; }
     return (
       <li className="nav-item">
-        <a href="#" role="tab"
+        <button role="tab"
            className={linkClass}
            onClick={this.props.linkClicked}
            >
           {this.props.children}
-        </a>
+        </button>
       </li>
     );
   }
diff --git a/hubs/static/client/app/components/WidgetChrome.js b/hubs/static/client/app/components/WidgetChrome.js
index 2cca9d8..019c35b 100644
--- a/hubs/static/client/app/components/WidgetChrome.js
+++ b/hubs/static/client/app/components/WidgetChrome.js
@@ -51,19 +51,19 @@ class WidgetChrome extends React.PureComponent {
         <div className="card-header">
           <DragHandle />
           {title}
-          <a href="#"
-            className="float-right text-danger pl-2"
+          <button
+            className="btn btn-link float-right text-danger pl-2"
             onClick={this.handleWidgetDeleted}
             >
             <i className="fa fa-trash" aria-hidden="true" title="Delete this widget"></i>
-          </a> 
+          </button>
           { this.props.widget.params.length > 0 &&
-          <a href="#"
-            className="float-right text-dark"
+          <button
+            className="btn btn-link float-right text-dark"
             onClick={this.handleEditButtonClicked}
             >
             <i className="fa fa-cog" aria-hidden="true"></i>
-          </a>
+          </button>
           }
         </div>
       );
diff --git a/hubs/static/client/app/components/feed/Feed.js b/hubs/static/client/app/components/feed/Feed.js
index a485878..cec079d 100644
--- a/hubs/static/client/app/components/feed/Feed.js
+++ b/hubs/static/client/app/components/feed/Feed.js
@@ -27,7 +27,7 @@ export default class Feed extends React.Component {
     });
     return (
       <div className="Feed">
-        { (items.length == 0 && this.props.loaded) ?
+        { (items.length === 0 && this.props.loaded) ?
           <p className="m-2">
             <FormattedMessage {...messages.no_items} tagName="i" />
           </p>
diff --git a/hubs/static/client/app/components/feed/ItemsGetter.js b/hubs/static/client/app/components/feed/ItemsGetter.js
index 2911f5c..2e2a146 100644
--- a/hubs/static/client/app/components/feed/ItemsGetter.js
+++ b/hubs/static/client/app/components/feed/ItemsGetter.js
@@ -50,7 +50,7 @@ class ItemsGetter extends React.Component {
     }
     const promise = new Promise((resolve, reject) => {
       this.setState({isLoading: true});
-      this.serverRequest = $.ajax({
+      this.serverRequest = jQuery.ajax({
         url: this.props.url,
         method: 'GET',
         dataType: 'json',
@@ -83,10 +83,14 @@ class ItemsGetter extends React.Component {
           "Cannot auto-update the feed, you will have to refresh " +
           "the page manually to see new elements."
         );
+        break;
       case 0:
         msg = (
           "Reconnecting to the auto-update source..."
         );
+        break;
+      default:
+        msg = null;
     }
     this.setState({errorMessage: msg});
   }
diff --git a/hubs/static/client/app/components/feed/Panel.js b/hubs/static/client/app/components/feed/Panel.js
index a11dbf6..db653b4 100644
--- a/hubs/static/client/app/components/feed/Panel.js
+++ b/hubs/static/client/app/components/feed/Panel.js
@@ -37,7 +37,7 @@ export default class Panel extends React.Component {
              Object.keys(this.props.item.msg_ids).length > 1) &&
             <div className="mt-auto">
               <small>
-                <a href="#" onClick={this.toggleDetails}>details</a>
+                <button className="btn btn-link" onClick={this.toggleDetails}>details</button>
               </small>
             </div>
           }
diff --git a/hubs/static/client/app/components/feed/__tests__/Feed.test.js b/hubs/static/client/app/components/feed/__tests__/Feed.test.js
index da1b793..7d25a0b 100644
--- a/hubs/static/client/app/components/feed/__tests__/Feed.test.js
+++ b/hubs/static/client/app/components/feed/__tests__/Feed.test.js
@@ -1,12 +1,9 @@
 /* eslint-env jasmine, jest */
 
 import React from 'react';
-import ReactDOM from 'react-dom';
 import {mount} from 'enzyme';
 
 import Feed from '../Feed';
-
-jest.mock("../Panel");
 import Panel from '../Panel';
 
 describe('Feed', () => {
@@ -22,7 +19,7 @@ describe('Feed', () => {
   });
 
   it('should create the children', () => {
-    const component = mount(
+    mount(
       <Feed items={items} />
     );
     expect(Panel.mock.calls.length).toEqual(3);
diff --git a/hubs/static/client/app/components/feed/__tests__/Panel.test.js b/hubs/static/client/app/components/feed/__tests__/Panel.test.js
index abdea82..42c27cd 100644
--- a/hubs/static/client/app/components/feed/__tests__/Panel.test.js
+++ b/hubs/static/client/app/components/feed/__tests__/Panel.test.js
@@ -18,25 +18,18 @@ describe('Panel', () => {
   };
 
   it('should render the actions block', () => {
-    let node;
     const component = shallow(
-      <Panel item={item} ref={(el) => {node = el; }} />
+      <Panel item={item} />
     );
     expect(component).toBeTruthy();
-
-    //const block = node.querySelector('div.ml-3.text-right');
     expect(component.find("div.ml-3.text-right")).toBeTruthy();
   });
 
   it('should show the details link', () => {
-    let node;
     const component = shallow(
-      <Panel item={item} ref={(el) => {node = el; }} />
+      <Panel item={item} />
     );
     expect(component).toBeTruthy();
-
-    //const details = node.querySelector('.text-right small a');
-
     expect(component.find(".text-right small a")).toBeTruthy();
   });
 });
diff --git a/hubs/static/client/app/core/Pages.js b/hubs/static/client/app/core/Pages.js
index 739028c..3a9445c 100644
--- a/hubs/static/client/app/core/Pages.js
+++ b/hubs/static/client/app/core/Pages.js
@@ -1,4 +1,3 @@
-import React from 'react';
 import {
   makeLoadable,
 } from '../core/utils';
diff --git a/hubs/static/client/app/core/actions/hub.js b/hubs/static/client/app/core/actions/hub.js
index 24cbe0e..843e37b 100644
--- a/hubs/static/client/app/core/actions/hub.js
+++ b/hubs/static/client/app/core/actions/hub.js
@@ -141,6 +141,7 @@ function associateError(dispatch, role, error) {
 export function associateUser(role) {
   return (dispatch, getState) => {
     const url = getState().urls.hub + role + "s";
+    dispatch(requestHubAssoc(role));
     return apiCall(url, {method: "POST"}).then(
       result => associateResponse(dispatch, role, result),
       error => associateError(dispatch, role, error)
@@ -151,6 +152,7 @@ export function associateUser(role) {
 export function dissociateUser(role) {
   return (dispatch, getState) => {
     const url = getState().urls.hub + role + "s";
+    dispatch(requestHubAssoc(role));
     return apiCall(url, {method: "DELETE"}).then(
       result => associateResponse(dispatch, role, result),
       error => associateError(dispatch, role, error)
diff --git a/hubs/static/client/app/core/actions/sse.js b/hubs/static/client/app/core/actions/sse.js
index 7c64955..fac58b3 100644
--- a/hubs/static/client/app/core/actions/sse.js
+++ b/hubs/static/client/app/core/actions/sse.js
@@ -75,6 +75,8 @@ export function sseEvent(type, data) {
           type: NEW_NOTIFICATION,
           username,
         });
+      default:
+        return;
     }
   }
 }
diff --git a/hubs/static/client/app/core/reducers/index.js b/hubs/static/client/app/core/reducers/index.js
index d8e40f1..64e12aa 100644
--- a/hubs/static/client/app/core/reducers/index.js
+++ b/hubs/static/client/app/core/reducers/index.js
@@ -4,7 +4,6 @@ import heartbeat from "./heartbeat";
 import sseReducer from "./sse";
 import {
   hubReducer,
-  hubEditMode,
   hubConfigDialogOpen,
   hubConfigDialogLoading,
   } from "./hub";
diff --git a/hubs/static/client/app/core/reducers/user.js b/hubs/static/client/app/core/reducers/user.js
index 3537e9d..434d426 100644
--- a/hubs/static/client/app/core/reducers/user.js
+++ b/hubs/static/client/app/core/reducers/user.js
@@ -1,7 +1,4 @@
 import {
-  HUB_ASSOC_SUCCESS,
-  } from '../actions/hub';
-import {
   USER_FETCH_SUCCESS,
   } from '../actions/user';
 
diff --git a/hubs/static/client/app/core/reducers/widget.js b/hubs/static/client/app/core/reducers/widget.js
index 1277ba8..0d93187 100644
--- a/hubs/static/client/app/core/reducers/widget.js
+++ b/hubs/static/client/app/core/reducers/widget.js
@@ -1,7 +1,6 @@
 import {
   WIDGET_PUT_REQUEST, WIDGET_PUT_SUCCESS, WIDGET_PUT_FAILURE,
   } from '../actions/widget';
-import { WIDGET_NEEDS_UPDATE } from '../actions/sse';
 
 
 export default function singleWidgetReducer(state, action) {
diff --git a/hubs/static/client/app/core/reducers/widgets.js b/hubs/static/client/app/core/reducers/widgets.js
index 0ceaf9d..ac1c969 100644
--- a/hubs/static/client/app/core/reducers/widgets.js
+++ b/hubs/static/client/app/core/reducers/widgets.js
@@ -7,7 +7,7 @@ import {
   } from '../actions/widgets';
 import {
   WIDGET_PUT_SUCCESS, WIDGET_DELETE_SUCCESS,
-  WIDGET_WILL_UPDATE, WIDGET_DID_UPDATE,
+  WIDGET_WILL_UPDATE,
   HUB_WIDGETS_ADD_REQUEST, HUB_WIDGETS_ADD_FAILURE,
   WIDGET_MOVE_REQUEST, WIDGET_MOVE_FAILURE,
   WIDGET_OPEN_CONFIG, WIDGET_CLOSE_CONFIG,
@@ -47,7 +47,7 @@ function widgetList(position) {
           widget => (widget.position === position)
         ).map(widget => widget.idx);
       case WIDGET_DELETE_SUCCESS:
-        return state.filter((idx) => (idx != action.widgetId));
+        return state.filter((idx) => (idx !== action.widgetId));
       case WIDGET_MOVE_REQUEST:
         // Optimistic update
         if (action.position !== position) {
@@ -75,7 +75,7 @@ function widgetsNeedUpdate(state=[], action) {
       if (state.indexOf(action.widgetId) === -1) {
         return state;
       } else {
-        return state.filter((idx) => (idx != action.widgetId));
+        return state.filter((idx) => (idx !== action.widgetId));
       }
     case WIDGET_PUT_SUCCESS:
     case WIDGET_NEEDS_UPDATE:
diff --git a/hubs/static/client/app/core/utils.js b/hubs/static/client/app/core/utils.js
index 09c0361..22e7f28 100644
--- a/hubs/static/client/app/core/utils.js
+++ b/hubs/static/client/app/core/utils.js
@@ -70,6 +70,7 @@ export function makeLoadable(loader, loadingText, errorText) {
   return AsyncComponent;
 }
 
+/*
 function makeSyncLoadable(loader) {
   class SyncLoadable extends React.Component {
     constructor(props) {
@@ -92,6 +93,7 @@ function makeSyncLoadable(loader) {
   }
   return SyncLoadable;
 }
+*/
 
 export function monogramColour(hubname) {
   var colours = ["blue", "green", "magenta", "orange", "purple"]
diff --git a/hubs/static/client/app/index.js b/hubs/static/client/app/index.js
index 4b97cc6..45664b8 100644
--- a/hubs/static/client/app/index.js
+++ b/hubs/static/client/app/index.js
@@ -1,15 +1,16 @@
-// Read the public path from the backend
-// https://webpack.js.org/guides/public-path/
-if(window.resourceBaseUrl) {
-  __webpack_public_path__ = window.resourceBaseUrl;
-}
-
 import React from 'react';
 import ReactDOM from 'react-dom';
 import getStore from "./core/store";
 import App from "./core/App";
 
 
+// Read the public path from the backend
+// https://webpack.js.org/guides/public-path/
+if (window.resourceBaseUrl) {
+   __webpack_public_path__ = window.resourceBaseUrl;
+}
+
+
 export function setupPage(elementId, initialState) {
   const store = getStore(initialState);
   ReactDOM.render(
diff --git a/hubs/static/client/app/widgets/feed/StreamFeed.js b/hubs/static/client/app/widgets/feed/StreamFeed.js
index 9d87e83..6b9d955 100644
--- a/hubs/static/client/app/widgets/feed/StreamFeed.js
+++ b/hubs/static/client/app/widgets/feed/StreamFeed.js
@@ -1,9 +1,4 @@
 import React from 'react';
-import PropTypes from 'prop-types';
-import {
-  defineMessages,
-  FormattedMessage,
-  } from 'react-intl';
 import { apiCall } from '../../core/utils';
 import TabSet from '../../components/TabSet';
 import ItemsGetter from '../../components/feed/ItemsGetter';
@@ -37,7 +32,7 @@ export default class StreamFeed extends React.Component {
   makeServerRequestCompletePromise() {
     // Only call this.props.onServerRequestStop when both server requests
     // are done, otherwise the first to reload will cancel the other's reload.
-    const promise = Promise.all([
+    Promise.all([
       ...this.serverRequestCompletePromises
     ]).finally(
       () => {
@@ -228,7 +223,7 @@ export default class StreamFeed extends React.Component {
 class FeedPanel extends React.Component {
 
   render() {
-    const filters_url = `https://apps.fedoraproject.org/notifications/${this.props.username}.id.fedoraproject.org/`;
+    //const filters_url = `https://apps.fedoraproject.org/notifications/${this.props.username}.id.fedoraproject.org/`;
 
     return (
       <div>
diff --git a/hubs/static/client/app/widgets/halp/ModalAllRequests.js b/hubs/static/client/app/widgets/halp/ModalAllRequests.js
index fde1719..2a8eb19 100644
--- a/hubs/static/client/app/widgets/halp/ModalAllRequests.js
+++ b/hubs/static/client/app/widgets/halp/ModalAllRequests.js
@@ -90,7 +90,7 @@ export default class ModalAllRequests extends React.Component {
     const formData = this.state.formData;
     formData.page = requestedPage || 1;
     this.setState({isLoading: true});
-    this.serverRequest = $.ajax({
+    this.serverRequest = jQuery.ajax({
       url: this.props.urls.search,
       method: 'GET',
       data: formData,
diff --git a/hubs/static/client/app/widgets/halp/ModalRequest.js b/hubs/static/client/app/widgets/halp/ModalRequest.js
index c066888..3fc1895 100644
--- a/hubs/static/client/app/widgets/halp/ModalRequest.js
+++ b/hubs/static/client/app/widgets/halp/ModalRequest.js
@@ -72,7 +72,7 @@ export default class ModalRequest extends React.Component {
                   <div className="media-left media-middle">
                     <a href={this.props.data.author.url} target="_blank">
                       <img className="square-32 img-circle"
-                           src={this.props.data.author.avatar} />
+                           src={this.props.data.author.avatar} alt="" />
                     </a>
                   </div>
                   <div className="media-body">
diff --git a/hubs/static/client/app/widgets/halp/Request.js b/hubs/static/client/app/widgets/halp/Request.js
index a6c0ec9..e3846d8 100644
--- a/hubs/static/client/app/widgets/halp/Request.js
+++ b/hubs/static/client/app/widgets/halp/Request.js
@@ -11,7 +11,7 @@ export default class Request extends React.Component {
   }
 
   onClick(e) {
-    e.preventDefault;
+    e.preventDefault();
     this.props.onZoomRequest(this.props.request);
   }
 
diff --git a/hubs/static/client/app/widgets/halp/RequestList.js b/hubs/static/client/app/widgets/halp/RequestList.js
index cc6a8d7..9839502 100644
--- a/hubs/static/client/app/widgets/halp/RequestList.js
+++ b/hubs/static/client/app/widgets/halp/RequestList.js
@@ -1,5 +1,4 @@
 import React from 'react';
-import PropTypes from 'prop-types';
 import {
   defineMessages,
   FormattedMessage,
diff --git a/hubs/static/client/app/widgets/halp/Widget.js b/hubs/static/client/app/widgets/halp/Widget.js
index 0ae6d86..333c5c9 100644
--- a/hubs/static/client/app/widgets/halp/Widget.js
+++ b/hubs/static/client/app/widgets/halp/Widget.js
@@ -70,10 +70,10 @@ export default class HalpWidget extends React.Component {
   loadFromServer() {
     let hubs = this.props.widget.config.hubs || [];
     hubs = hubs.filter((hub) => (this.state.inactiveHubs.indexOf(hub) === -1));
-    const params = hubs.length > 0 ? $.param({hubs}, true) : "hubs=";
+    const params = hubs.length > 0 ? jQuery.param({hubs}, true) : "hubs=";
     this.props.dispatch(widgetWillUpdate(this.props.widget.idx));
     this.setState({isLoading: true});
-    this.serverRequest = $.ajax({
+    this.serverRequest = jQuery.ajax({
       url: this.props.widget.urls.data,
       method: 'GET',
       data: params,
diff --git a/hubs/static/client/app/widgets/halp/__tests__/RequestList.test.js b/hubs/static/client/app/widgets/halp/__tests__/RequestList.test.js
index 02958e1..30d7ad8 100644
--- a/hubs/static/client/app/widgets/halp/__tests__/RequestList.test.js
+++ b/hubs/static/client/app/widgets/halp/__tests__/RequestList.test.js
@@ -2,7 +2,6 @@
 
 
 import React from 'react';
-import ReactDOM from 'react-dom';
 import { IntlProvider } from 'react-intl';
 import { mount } from 'enzyme';
 
diff --git a/hubs/static/client/app/widgets/halp/getRequestView.js b/hubs/static/client/app/widgets/halp/getRequestView.js
index 13e3d17..48adc04 100644
--- a/hubs/static/client/app/widgets/halp/getRequestView.js
+++ b/hubs/static/client/app/widgets/halp/getRequestView.js
@@ -50,7 +50,7 @@ export default function getRequestView(request, openCallback) {
             className="d-flex mr-3"
             >
             <img className="square-32 img-circle"
-                 src={request.author.avatar} />
+                 src={request.author.avatar} alt="" />
           </a>
           <div className="media-body align-self-center">
             <a href={request.author.url}>
diff --git a/hubs/static/client/app/widgets/irc/ChatClient.js b/hubs/static/client/app/widgets/irc/ChatClient.js
index eb16c50..af69a14 100644
--- a/hubs/static/client/app/widgets/irc/ChatClient.js
+++ b/hubs/static/client/app/widgets/irc/ChatClient.js
@@ -1,5 +1,4 @@
 import React from 'react';
-import PropTypes from 'prop-types';
 
 
 export default class ChatClient extends React.Component {
@@ -11,6 +10,7 @@ export default class ChatClient extends React.Component {
         src={url}
         className="webchat"
         style={{height: `${this.props.height}px`}}
+        title="chat"
         ></iframe>
     );
   }
diff --git a/hubs/static/client/app/widgets/issues/Footer.js b/hubs/static/client/app/widgets/issues/Footer.js
index 79ae7b5..55cfc60 100644
--- a/hubs/static/client/app/widgets/issues/Footer.js
+++ b/hubs/static/client/app/widgets/issues/Footer.js
@@ -34,7 +34,12 @@ export default class Footer extends React.Component {
               <div className="dropdown-item">
                 <a target="blank"
                    href={this.props.counts.bugzilla.link}>
-                  <img src="https://bugzilla.redhat.com/favicon.ico" style={{height: '16px'}} className={"mr-2"}/>
+                  <img
+                    src="https://bugzilla.redhat.com/favicon.ico"
+                    style={{height: '16px'}}
+                    className="mr-2"
+                    alt=""
+                    />
                   Bugzilla ({this.props.counts.bugzilla.count})
                 </a>
               </div>
@@ -43,7 +48,12 @@ export default class Footer extends React.Component {
               <div className="dropdown-item">
                 <a target="blank"
                    href={this.props.counts.github.link}>
-                  <img src="https://github.com/favicon.ico" style={{height: '16px'}} className={"mr-2"}/>
+                  <img
+                    src="https://github.com/favicon.ico"
+                    style={{height: '16px'}}
+                    className="mr-2"
+                    alt=""
+                    />
                   Github ({this.props.counts.github.count})
                 </a>
               </div>
@@ -52,7 +62,12 @@ export default class Footer extends React.Component {
               <div className="dropdown-item">
                 <a target="blank"
                    href={this.props.counts.pagure.link}>
-                  <img src="https://pagure.io/static/favicon.ico" style={{height: '16px'}} className={"mr-2"}/>
+                  <img
+                    src="https://pagure.io/static/favicon.ico"
+                    style={{height: '16px'}}
+                    className="mr-2"
+                    alt=""
+                    />
                   Pagure ({this.props.counts.pagure.count})
                 </a>
               </div>
diff --git a/hubs/static/client/app/widgets/issues/Issue.js b/hubs/static/client/app/widgets/issues/Issue.js
index eb5094b..173aeab 100644
--- a/hubs/static/client/app/widgets/issues/Issue.js
+++ b/hubs/static/client/app/widgets/issues/Issue.js
@@ -17,7 +17,12 @@ export default class Issue extends React.Component {
           <div className="col-md-6">
             <div className="float-right">
               <span>{this.props.issue.project}</span>
-              <img src={this.props.issue.icon} style={{height: '16px'}} className={"ml-2"}/>
+              <img
+                src={this.props.issue.icon}
+                style={{height: '16px'}}
+                className="ml-2"
+                alt=""
+                />
             </div>
           </div>
         </div>
diff --git a/hubs/static/client/app/widgets/library/AddLinkDialog.js b/hubs/static/client/app/widgets/library/AddLinkDialog.js
index f8c4c30..4a4e047 100644
--- a/hubs/static/client/app/widgets/library/AddLinkDialog.js
+++ b/hubs/static/client/app/widgets/library/AddLinkDialog.js
@@ -1,5 +1,4 @@
 import React from 'react';
-import PropTypes from 'prop-types';
 import { apiCall } from '../../core/utils';
 import Modal from '../../components/Modal';
 import SelectLinkForm from "./SelectLinkForm";
diff --git a/hubs/static/client/app/widgets/library/EditLinkDialog.js b/hubs/static/client/app/widgets/library/EditLinkDialog.js
index cd4a990..a953f85 100644
--- a/hubs/static/client/app/widgets/library/EditLinkDialog.js
+++ b/hubs/static/client/app/widgets/library/EditLinkDialog.js
@@ -1,5 +1,4 @@
 import React from 'react';
-import PropTypes from 'prop-types';
 import Modal from '../../components/Modal';
 import EditLinkForm from "./EditLinkForm";
 
diff --git a/hubs/static/client/app/widgets/library/EditLinkForm.js b/hubs/static/client/app/widgets/library/EditLinkForm.js
index b18d82f..e2c43f1 100644
--- a/hubs/static/client/app/widgets/library/EditLinkForm.js
+++ b/hubs/static/client/app/widgets/library/EditLinkForm.js
@@ -1,5 +1,4 @@
 import React from 'react';
-import PropTypes from 'prop-types';
 import Spinner from "../../components/Spinner";
 import MissingThumb from "./library-missing-thumb-large.png";
 
diff --git a/hubs/static/client/app/widgets/library/Link.js b/hubs/static/client/app/widgets/library/Link.js
index 842d201..2651388 100644
--- a/hubs/static/client/app/widgets/library/Link.js
+++ b/hubs/static/client/app/widgets/library/Link.js
@@ -12,6 +12,7 @@ export default class Link extends React.Component {
           <img
             className="link-preview mt-2"
             src={this.props.image || MissingThumb}
+            alt=""
             />
         </div>
         <div className={`media-body ${this.props.showDropdown ? "pr-3" : ""}`}>
@@ -19,33 +20,29 @@ export default class Link extends React.Component {
             <div
               className="dropdown"
               >
-              <a
-                className="text-secondary dropdown-toggle"
-                href="#"
-                role="button"
+              <button
+                className="btn btn-link text-secondary dropdown-toggle"
                 data-toggle="dropdown"
                 aria-haspopup="true"
                 aria-expanded="false"
                 >
-              </a>
+              </button>
               <div
                 className="dropdown-menu dropdown-menu-right"
                 aria-labelledby="dropdownMenuLink"
                 >
-                <a
-                  className="dropdown-item"
-                  href="#"
+                <button
+                  className="btn btn-link dropdown-item"
                   onClick={this.props.onEdit}
                   >
                   Edit item
-                </a>
-                <a
-                  className="dropdown-item"
-                  href="#"
+                </button>
+                <button
+                  className="btn btn-link dropdown-item"
                   onClick={this.props.onDelete}
                   >
                   Delete
-                </a>
+                </button>
               </div>
             </div>
           }
diff --git a/hubs/static/client/app/widgets/library/SelectLinkForm.js b/hubs/static/client/app/widgets/library/SelectLinkForm.js
index bc7db75..6a0f81f 100644
--- a/hubs/static/client/app/widgets/library/SelectLinkForm.js
+++ b/hubs/static/client/app/widgets/library/SelectLinkForm.js
@@ -1,5 +1,4 @@
 import React from 'react';
-import PropTypes from 'prop-types';
 import Spinner from "../../components/Spinner";
 
 
diff --git a/hubs/static/client/package.json b/hubs/static/client/package.json
index 00402c6..99a3c05 100644
--- a/hubs/static/client/package.json
+++ b/hubs/static/client/package.json
@@ -41,6 +41,7 @@
     "enzyme": "^3.0.0",
     "enzyme-adapter-react-15": "^1.0.0",
     "eslint": "^4.4.1",
+    "eslint-config-react-app": "^2.1.0",
     "eslint-loader": "^1.9.0",
     "eslint-plugin-react": "^7.2.1",
     "extract-text-webpack-plugin": "^3.0.0",
diff --git a/hubs/templates/master.html b/hubs/templates/master.html
index 090303b..5154251 100644
--- a/hubs/templates/master.html
+++ b/hubs/templates/master.html
@@ -195,6 +195,7 @@
 <script src="https://unpkg.com/react-dom@15/dist/react-dom{% if not config.DEBUG %}.min{% endif %}.js"></script>
 <script>
 {# Inform the JS UI of the public build path. It *must* end with a slash. #}
+{# https://webpack.js.org/guides/public-path/ #}
 window.resourceBaseUrl = {{ url_for('static', filename='js/build/') | tojson }};
 </script>
 <script src="{{ url_for('static', filename='js/build/common.js') }}"></script>