PR#527: remove mailing_list_url from fas group sync - fedora-hubs

fedora-hubs

#527 remove mailing_list_url from fas group sync

Closed 6 years ago by abompard. Opened 6 years ago by ryanlerch.

ryanlerch/fedora-hubs fix-mailing_list_url into develop

remove mailing_list_url from fas group sync

Ryan Lerch • 6 years ago

ec9e0ad

hubs/utils/fas.py

file modified

-1

		`@@ -48,7 +48,6 @@`
		`"irc_network": "chat_domain",`
		`"irc_channel": "chat_channel",`
		`"mailing_list": "mailing_list",`
		`- "mailing_list_url": "mailing_list_url",`
		`}`
		`for fas_attr, hub_attr in attr_map.items():`
		`if fas_group[fas_attr] is None:`

ryanlerch commented 6 years ago

If trying to edit any group that had been synced from FAS, the config dialog complained about an invalid key mailing_list_url. Since the mailing list item in both fas and hubs is named mailing_list, this removes the mailing_list_url field from being created in the FAS sync, and the config dialong now works as expected.

abompard commented 6 years ago

Actually, we need that info to display it in the HubCommunity box. So the bug is because that field is not authorized in hubs.models.hubconfig.HubConfigProxy.

abompard commented 6 years ago

I'm going to close this PR and fix the issue with this patch:

diff --git a/hubs/models/hubconfig.py b/hubs/models/hubconfig.py
index b654dca2..06c6c8b5 100644
--- a/hubs/models/hubconfig.py
+++ b/hubs/models/hubconfig.py
@@ -105,6 +105,7 @@ class HubConfigProxy(MutableMapping):
         "visibility", "chat_domain", "chat_channel", "mailing_list",
         "calendar", "meetings_text", "rules_url", "timezone_offset",
         "chat_nickname", "email", "creation_date", "country",
+        "mailing_list_url",
     ) + tuple(p["name"] for p in DEV_PLATFORMS)
     CONVERTERS = {
         "archived": BooleanConverter(),