PR#410: Addresses issue #353 - fedora-hubs

anar • 6 years ago

f852fb2

anar • 6 years ago

20f07bf

hubs/tests/widgets/test_pagure_pr.py

file added

+54

		`@@ -0,0 +1,54 @@`
		`+ from __future__ import unicode_literals`
		`+`
		`+ from . import WidgetTest`
		`+`
		`+`
		`+ class TestPagurePr(WidgetTest):`
		`+`
		`+ plugin = "pagure_pr"`
		`+ initial_widget_config = {`
		`+ "repo": "fedora-hubs",`
		`+ }`
		`+`
		`+ def populate(self):`
		`+ super(TestPagurePr, self).populate()`
		`+ self._add_widget_under_test()`
		`+`
		`+ def _get_should_invalidate_result(self, msg):`
		`+ func = self.widget.module.get_cached_functions()['GetPRs']`
		`+ return func(self.widget).should_invalidate(msg)`
		`+`
		`+ def test_should_invalidate_wrong_topic(self):`
		`+ msg = {'topic': 'hubs.widget.update.WRONG.TOPIC'}`
		`+ self.assertFalse(self._get_should_invalidate_result(msg))`
		`+`
		`+ def test_should_invalidate_good_match(self):`
		`+ msg = {`
		`+ 'topic': 'tests.pagure.pull-request.new',`
		`+ 'msg': {`
		`+ "project": {`
		`+ "name": "fedora-hubs",`
		`+ },`
		`+ },`
		`+ }`
		`+ self.assertTrue(self._get_should_invalidate_result(msg))`
		`+ msg = {`
		`+ 'topic': 'tests.pagure.pull-request.closed',`
		`+ 'msg': {`
		`+ "project": {`
		`+ "name": "fedora-hubs",`
		`+ },`
		`+ },`
		`+ }`
		`+ self.assertTrue(self._get_should_invalidate_result(msg))`
		`+`
		`+ def test_should_invalidate_wrong_repo(self):`
		`+ msg = {`
		`+ 'topic': 'tests.pagure.pull-request.new',`
		`+ 'msg': {`
		`+ "project": {`
		`+ "name": "not-fedora-hubs",`
		`+ },`
		`+ },`
		`+ }`
		`+ self.assertFalse(self._get_should_invalidate_result(msg))`

hubs/widgets/pagure_pr/__init__.py

file modified

+2 -3

		`@@ -72,9 +72,8 @@`
		`)`

		`def should_invalidate(self, message):`
		`- category = message["topic"].split('.')[3]`
		`- if category != "pagure":`
		`- # TODO -- this could be honed in more to just PRs`
		`+ if (".pagure.pull-request.new" not in message["topic"]`
		`+ and ".pagure.pull-request.closed" not in message["topic"]):`
		`return False`
		`try:`
		`project = message['msg']['project']['name']`