PR#244: Fix test failing due to additional HTML attributes - fedora-hubs

fedora-hubs

#244 Fix test failing due to additional HTML attributes

Merged 7 years ago by skrzepto. Opened 7 years ago by lsedlar.

lsedlar/fedora-hubs fix-tests into develop

Fix test failing due to additional HTML attributes

Lubomír Sedlář • 7 years ago

cb8f2c4

hubs/tests/test_fedora_hubs_flask_api.py

file modified

+2 -2

		`@@ -37,8 +37,8 @@`
		`with tests.auth_set(app, None): # check_auth doesn't load in unittest`
		`result = self.app.get('/ralph', follow_redirects=True)`
		`self.assertEqual(result.status_code, 200)`
		`- str_expected = '<h5>Ralph</h5>'`
		`- self.assertTrue(str_expected in result.data)`
		`+ match_expected = r'<h5[^>]*>Ralph</h5>'`
		`+ self.assertRegexpMatches(result.data, match_expected)`
		`str_expected = 'Not logged in.'`
		`self.assertTrue(str_expected in result.data)`

lsedlar commented 7 years ago

The HTML contains an attribute which causes the expected string to not
be found. This patch updates the test to use a regular expression, which
should be a tad more reliable.