#565 Crash from fedmsg message
Closed: Fixed 4 years ago Opened 4 years ago by ryanlerch.

the backend crashed with the following traceback:

18:15:25 triage.1       | Traceback (most recent call last):                                                           
18:15:25 triage.1       |   File "/usr/local/bin/fedora-hubs-triage", line 11, in <module>                             
18:15:25 triage.1       |     load_entry_point('fedora-hubs', 'console_scripts', 'fedora-hubs-triage')()               
18:15:25 triage.1       |   File "/srv/hubs/fedora-hubs/hubs/backend/triage.py", line 217, in main                     
18:15:25 triage.1       |     for task in triage(msg):     
18:15:25 triage.1       |   File "/srv/hubs/fedora-hubs/hubs/backend/triage.py", line 144, in triage                   
18:15:25 triage.1       |     hubs.feed.on_new_message(msg)
18:15:25 triage.1       |   File "/srv/hubs/fedora-hubs/hubs/feed.py", line 125, in on_new_message                     
18:15:25 triage.1       |     fedmsg.meta.conglomerate([msg])                                                          
18:15:25 triage.1       |   File "/usr/lib/python3.6/site-packages/fedmsg/meta/__init__.py", line 207, in conglomerate 
18:15:25 triage.1       |     [message], subject=subject, lexers=lexers, **config)                                     
18:15:25 triage.1       |   File "/usr/lib/python3.6/site-packages/fedmsg/meta/base.py", line 328, in produce_template 
18:15:25 triage.1       |     }) for msg in constituents]) 
18:15:25 triage.1       |   File "/usr/lib/python3.6/site-packages/fedmsg/meta/base.py", line 328, in <listcomp>       
18:15:25 triage.1       |     }) for msg in constituents]) 
18:15:25 triage.1       |   File "/usr/lib/python3.6/site-packages/fedmsg/meta/__init__.py", line 152, in __wrapper    
18:15:25 triage.1       |     return f(msg, **config)      
18:15:25 triage.1       |   File "/usr/lib/python3.6/site-packages/fedmsg/meta/__init__.py", line 171, in __wrapper    
18:15:25 triage.1       |     return f(msg, processor=processor, **config)                                             
18:15:25 triage.1       |   File "/usr/lib/python3.6/site-packages/fedmsg/meta/__init__.py", line 274, in msg2link     
18:15:25 triage.1       |     return processor.link(msg, **config)                                                     
18:15:25 triage.1       |   File "/usr/lib/python3.6/site-packages/fedmsg_meta_fedora_infrastructure/compose.py", line 131, in link                                                                                                           
18:15:25 triage.1       |     int(branch)                  
18:15:25 triage.1       | ValueError: invalid literal for int() with base 10: 'bikeshed'

I think that you should probably look at using fedmsg-hub, or otherwise catch any exceptions, as there will be more.

Yeah we ended up catching all exceptions in 86f39f7 and 6bb0b5e, I think that this bug is fixed.

Metadata Update from @abompard:
- Issue assigned to abompard
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

4 years ago

Login to comment on this ticket.

Metadata