#522 Crash from fedmsg message
Closed: Fixed 6 years ago Opened 6 years ago by ryanlerch.

My backend crashed with the following traceback:

05:26:46 worker.1       | Traceback (most recent call last):
05:26:46 worker.1       |   File "/srv/hubs/venv/bin/fedora-hubs-worker", line 11, in <module>
05:26:46 worker.1       |     load_entry_point('fedora-hubs', 'console_scripts', 'fedora-hubs-worker')()
05:26:46 worker.1       |   File "/srv/hubs/fedora-hubs/hubs/backend/worker.py", line 115, in main
05:26:46 worker.1       |     handle_widget_cache(db, item['idx'], item['fn_name'])
05:26:46 worker.1       |   File "/srv/hubs/fedora-hubs/hubs/backend/worker.py", line 62, in handle_widget_cache
05:26:46 worker.1       |     widget_cache_work(widget_idx, fn_name)
05:26:46 worker.1       |   File "/srv/hubs/fedora-hubs/hubs/backend/worker.py", line 56, in widget_cache_work
05:26:46 worker.1       |     fn_class(widget).rebuild()
05:26:46 worker.1       |   File "/srv/hubs/fedora-hubs/hubs/widgets/caching.py", line 144, in rebuild
05:26:46 worker.1       |     self.get_data()
05:26:46 worker.1       |   File "/srv/hubs/fedora-hubs/hubs/widgets/caching.py", line 69, in get_data
05:26:46 worker.1       |     key, self.execute, should_cache_fn=self._should_cache)
05:26:46 worker.1       |   File "/usr/lib/python2.7/site-packages/dogpile/cache/region.py", line 825, in get_or_create
05:26:47 worker.1       |     async_creator) as value:
05:26:47 worker.1       |   File "/usr/lib/python2.7/site-packages/dogpile/lock.py", line 154, in __enter__
05:26:47 worker.1       |     return self._enter()
05:26:47 worker.1       |   File "/usr/lib/python2.7/site-packages/dogpile/lock.py", line 94, in _enter
05:26:47 worker.1       |     generated = self._enter_create(createdtime)
05:26:47 worker.1       |   File "/usr/lib/python2.7/site-packages/dogpile/lock.py", line 145, in _enter_create
05:26:47 worker.1       |     created = self.creator()
05:26:47 worker.1       |   File "/usr/lib/python2.7/site-packages/dogpile/cache/region.py", line 792, in gen_value
05:26:47 worker.1       |     created_value = creator()
05:26:47 worker.1       |   File "/srv/hubs/fedora-hubs/hubs/widgets/feed/functions.py", line 18, in execute
05:26:47 worker.1       |     msgs = fedmsg.meta.conglomerate(raw_msgs)
05:26:47 worker.1       |   File "/usr/lib/python2.7/site-packages/fedmsg/meta/__init__.py", line 197, in conglomerate
05:26:47 worker.1       |     [message], subject=subject, lexers=lexers, **config)
05:26:47 worker.1       |   File "/usr/lib/python2.7/site-packages/fedmsg/meta/base.py", line 328, in produce_template
05:26:47 worker.1       |     }) for msg in constituents])
05:26:47 worker.1       |   File "/usr/lib/python2.7/site-packages/fedmsg/meta/__init__.py", line 142, in __wrapper
05:26:47 worker.1       |     return f(msg, **config)
05:26:47 worker.1       |   File "/usr/lib/python2.7/site-packages/fedmsg/meta/__init__.py", line 161, in __wrapper
05:26:47 worker.1       |     return f(msg, processor=processor, **config)
05:26:47 worker.1       |   File "/usr/lib/python2.7/site-packages/fedmsg/meta/__init__.py", line 236, in msg2subtitle
05:26:47 worker.1       |     return processor.subtitle(msg, **config)
05:26:47 worker.1       |   File "/usr/lib/python2.7/site-packages/fedmsg_meta_fedora_infrastructure/mediawiki.py", line 41, in subtitle
05:26:47 worker.1       |     description = msg['msg']['description'][:35]
05:26:47 worker.1       | TypeError: 'bool' object has no attribute '__getitem__'
05:26:47 worker.1       | process terminated

Ew, that's a crash when we call conglomerate(), not much we can do about it apart from catching the exception. I don't know what to do after that though, maybe drop the message since it's invalid?

Login to comment on this ticket.

Metadata