#472 Contact widget: check that the location isn't displayed if it is set to private in FAS
Closed: Fixed 4 years ago Opened 4 years ago by abompard.

See title ;-)


Metadata Update from @abompard:
- Issue priority set to: High

4 years ago

Metadata Update from @abompard:
- Issue set to the milestone: Production

4 years ago

Apparently the FAS API doesn't give the location when it's set to private, so just make sure the UI doesn't crash if the field is absent.

Metadata Update from @ryanlerch:
- Issue assigned to shaily

4 years ago

The UserContact component uses the following FAS fields:
country_code, timezone, email, ircnick, creation

From the FAS source code, when privacy is turned on, the only fields that are actually rendered in the component are creation and email since the others aren't returned by the API.

I'll make a PR before the meeting today to accommodate for this in hubs.utils.fas and add conditional rendering to the component.

Metadata Update from @ryanlerch:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

4 years ago

Login to comment on this ticket.

Metadata