PR#8: Hotpatch for Bodhi 4 - fedora-easy-karma

fedora-easy-karma

#8 Hotpatch for Bodhi 4

Closed 4 years ago by kparal. Opened 4 years ago by churchyard.

churchyard/fedora-easy-karma bodhi4 into master

Hotpatch for Bodhi 4

Miro Hrončok • 4 years ago

e039292

fedora-easy-karma.py

file modified

+3 -4

		`@@ -190,8 +190,6 @@`

		`# the format of the user has changed, add a data member`
		`comment["username"] = comment["user"]["name"]`
		`- if comment["anonymous"]:`
		`- comment["username"] += " (unauthenticated)"`

		`comments.append(`
		`"%(indent)s%(username)s - %(timestamp)s "`
		`@@ -222,6 +220,7 @@`
		`values["karma_status"] = "%d/%s" % (values["karma"],`
		`values["stable_karma"])`

		`+ values["submitter"] = values["user"]["name"]`
		`return format_string % values`

		`@staticmethod`
		`@@ -653,7 +652,7 @@`

		`# Ignore own updates`
		`if self.options.ignore_own and \`
		`- update["submitter"] == self.options.fas_username:`
		`+ update["user"]["name"] == self.options.fas_username:`
		`continue`

		`if update not in processed_updates and \`
		`@@ -773,7 +772,7 @@`

		`def already_commented(self, update, user):`
		`for comment in update["comments"]:`
		`- if not comment["anonymous"] and comment["user"]["name"] == user:`
		`+ if comment["user"]["name"] == user:`
		`return True`
		`return False`

churchyard commented 4 years ago

See https://bugzilla.redhat.com/show_bug.cgi?id=1714925

till commented 4 years ago

Am 2=2E Juli 2019 23:22:12 MESZ schrieb "Miro Hron=C4=8Dok" pagure@pagure= =2Eio:

churchyard opened a new pull-request against the project:
fedora-easy-karma that you are following:
Hotpatch for Bodhi 4

To reply, visit the link below or just reply to this email
https://pagure=2Eio/fedora-easy-karma/pull-request/8

Thank you Miro,

It would be great if you can merge this or apply it as a downstream patch =
if you cannot merge it=2E Please also apply #7 downstream (but do not merge=
it)=2E Thank you!

churchyard commented 4 years ago

I can apply both downstream.

churchyard commented 4 years ago

https://src.fedoraproject.org/rpms/fedora-easy-karma/pull-request/3
https://src.fedoraproject.org/rpms/fedora-easy-karma/pull-request/4
https://src.fedoraproject.org/rpms/fedora-easy-karma/pull-request/5

kparal commented 4 years ago

I'm going to merge this. It's working fine, we've run with this as a downstream patch for months. It's required, otherwise FEK crashes. Also it will simplify the other pending patches we have.

churchyard commented 4 years ago

Please do.

kparal commented 4 years ago

I added one further changed line from the local bodhi4 branch and merged it as https://pagure.io/fedora-easy-karma/c/b8a6ff988 . That allows us to delete bodhi4 branch as well.