fedora-docs / template

#4 Issue 3 - Check if sudo is really required to run docker
Merged by pbokoc. Opened by pbokoc.
fedora-docs/ pbokoc/template iss3  into  master

Download 4.patch

This is a simple fix that adds a check for whether the user running the script is in the docker group or not. If they are, the command is run without sudo, if they are not, it's the same command with sudo and a message pointing out you can avoid that.

Fixes #3.

Yaaaay, this is exactly what I hoped for. Thanks @pbokoc! +1 from me. :thumbsup:

I'm mostly +1.

Let's educate people it is not a good security practise, but let's make it work for them if they've already done that and they know what they're doing.

1 new commit added

  • Provide better messages on the command line

The terminal output is much better now, including a link to upstream Docker docs that talk about both how to actually add your user to the group as well as potential security problems stemming from that.

I'm all for it, thanks @pbokoc !

Pull-Request has been merged by pbokoc
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.