#21 Fix overquoting for ${cmd}
Merged by pbokoc. Opened by siosm.
Unknown source main

Download 21.patch

Fixes:

$ ./build.sh
This build script is using Podman to run the build in an isolated environment.
antora: option '--html-url-extension-style <choice>' argument 'indexify site.yml' is invalid. Allowed choices are default, drop, indexify.

Patch works for me.

On Fedora 36 (branched) the preview web server serves website, but prints exceptions. They do not happen with the same file each time. Sometimes you must kill preview with Ctrl+c and restart it. The patch does not cause it. How to proceed with this?

$ ./preview.sh 
The preview is available at http://localhost:8080
Serving HTTP on 0.0.0.0 port 8080 (http://0.0.0.0:8080/) ...
127.0.0.1 - - [05/Mar/2022 11:52:17] "GET / HTTP/1.1" 200 -
127.0.0.1 - - [05/Mar/2022 11:52:17] "GET /pizza-factory/ HTTP/1.1" 200 -
----------------------------------------
Exception occurred during processing of request from ('127.0.0.1', 59664)
Traceback (most recent call last):
  File "/usr/lib64/python3.10/socketserver.py", line 683, in process_request_thread
    self.finish_request(request, client_address)
  File "/usr/lib64/python3.10/socketserver.py", line 360, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/usr/lib64/python3.10/http/server.py", line 653, in __init__
    super().__init__(*args, **kwargs)
  File "/usr/lib64/python3.10/socketserver.py", line 747, in __init__
    self.handle()
  File "/usr/lib64/python3.10/http/server.py", line 427, in handle
    self.handle_one_request()
  File "/usr/lib64/python3.10/http/server.py", line 415, in handle_one_request
    method()
  File "/usr/lib64/python3.10/http/server.py", line 660, in do_GET
    self.copyfile(f, self.wfile)
  File "/usr/lib64/python3.10/http/server.py", line 860, in copyfile
    shutil.copyfileobj(source, outputfile)
  File "/usr/lib64/python3.10/shutil.py", line 198, in copyfileobj
    fdst_write(buf)
  File "/usr/lib64/python3.10/socketserver.py", line 826, in write
    self._sock.sendall(b)
BrokenPipeError: [Errno 32] Broken pipe
...

@sobek that indeed seems like an unrelated issue. I'm going to merge this PR; I'd suggest you start a thread on the forums here if the problem persists and hopefully someone will be able to help: https://discussion.fedoraproject.org/tag/docs

Pull-Request has been merged by pbokoc

Metadata