#3 Don't require sudo for build.sh and preview.sh
Closed 5 years ago Opened 5 years ago by jflory7.

It is slightly less tedious to not require sudo every time I want to test new changes and build out my doc sites. Per the existing instructions on the Fedora Developer Portal, an admin can add themselves to the docker group to successfully run containers without requiring root privileges.

I think it's safe to assume most users using Docker will do this. And if not, the scripts can check if the user has permissions, and if not, it can point them to the Developer Portal.

What do you think?


If we can check for this, I'd rather have it fall back on sudo, possibly with a note, but not just have a note.

@bex I think it's a good compromise. :thumbsup:

Metadata Update from @pbokoc:
- Issue assigned to pbokoc (was: asamalik)

5 years ago

I'm not a big fan of the "docker" group, as that basically makes you root, which is a bad security practise.

Podman, an alternative container runtime to Docker that doesn't require big fat daemons to run on your system, can run containers without root. But last time I tried it it couldn't use the "port" option without root. So we can use it for build.sh, but not for preview.sh.

So personally, I would either wait for Podman to be able to use "port" without root, or tried to find a web server on the system (is there something always on Fedora, maybe in python?). But it's just my personal preference.

That one actually looks good!

Let's not encourage it, but if someone already did it, let's make it work for them. +1

Alright, merged, thanks everyone.

Metadata Update from @pbokoc:
- Issue status updated to: Closed (was: Open)

5 years ago

Login to comment on this ticket.

Metadata